OpenStack Dashboard (Horizon)

TabGroups don't handle bad GET params

Bug #1291567 reported by Matthew D. Wood
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Matthew D. Wood
OpenStack Dashboard (Horizon) 2014.2 "juno"

Bug Description

TabGroups and thus TabViews and TabbedTableViews don't handle bad GET params well.

We found this during penetration testing:
    project/volumes/?tab=<!--
results in a "ValueError: need more than 1 value to unpack" error.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80058

Changed in horizon:
assignee: nobody → Matthew D. Wood (woodm1979)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/80058
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7ff0dc2efe9ca2906e9a8e532f5cd5a4e24d557e
Submitter: Jenkins
Branch: master

commit 7ff0dc2efe9ca2906e9a8e532f5cd5a4e24d557e
Author: woodm1979 <email address hidden>
Date: Wed Mar 12 13:18:16 2014 -0600

    Ensure TabGroup to handle bad GET parameter

    TabGroups and thus TabViews and TabbedTableViews don't handle bad GET
    params well.

    Example: project/volumes/?tab=<!--
    results in a "ValueError: need more than 1 value to unpack" error.

    Change-Id: I7faf4f8c1c5c1f0ea078615282e7a7fbae2384b2
    Closes-Bug: 1291567

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.