Translator cannot control the word order of "update the extra spec value for"

Bug #1291513 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

In openstack_dashboard/dashboards/admin/flavors/templates/flavors/extras/_edit.html,
"Update the "extra spec" value for" and "key" variable are concatenated so translators cannot control the word order.

We should use blockquote.

- <p>{% trans 'Update the "extra spec" value for' %} &quot;{{ key }}&quot;</p>
+ <p>{% blocktrans %}Update the "extra spec" value for &quot;{{ key }}&quot;{% endblocktrans %}</p>

Tags: i18n
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80032

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/80032
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=15524b899befd0d4101e6b93a531925dddea05a6
Submitter: Jenkins
Branch: master

commit 15524b899befd0d4101e6b93a531925dddea05a6
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 13 02:48:40 2014 +0900

    Allow translator to control the word order (update extra spec)

    Change-Id: Ia7aeeef0e8cc957a9167cdfe89f12f3c327a52b8
    Closes-Bug: #1291513

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.