New Neutron unauthorised exception

[Julie Pichon]

In case of token expiry, the Neutron client tries to refresh the token - but if the auth_url isn't specified it can fail to do so (auth_url isn't a required value when authenticating with a token). The Neutron client was recently updated to properly handle this case and raise an exception.

https://review.openstack.org/#/c/53461/

This new exception should be added to the dashboard list of unauthorised exceptions, I think, in order to be handled it correctly - that is, return a forbidden/unauthorised error rather than internal server error.

https://github.com/openstack/horizon/blob/master/openstack_dashboard/exceptions.py

[Akihiro Motoki (amotoki)]

I am working on bug 1284317 in neutronclient. The base class of (newly introduced) NoAuthURLProvided exception looks inappropriate and it seems Unauthorized is a better base class.

[Akihiro Motoki (amotoki)]

It is related to neutronclient. I will take care of it.

[Akihiro Motoki (amotoki)]

I am working on rearranging neutronclient exceptions in bug 1296148 and https://review.openstack.org/82319.
I will do my best to merge it soon. In this patch, NoAuthURLProvided now inherits Unauthorized. Once the patch is merged, there is no need to modify Horizon related to this bug.

The issue reported in this bug is related to unreleased neutronclient and I hope the fix of bug 1296148 (above) is also a part of the next release of neutronclient. If not, I will propose a patch to address this issue.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/82320

[Akihiro Motoki (amotoki)]

Hi Julie,

Let me clarify more. At now, neutronclient is instantiated with auth_url in openstack_dashboard.api.neutron [1]. I think the newly added exception NoAuthURLProvided is never raised in Horizon.

Are you suggesting removing auth_url from neutronclient() in openstack_dashboard.api.neutron and handling token expiry in Horizon side?

[1] http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/api/neutron.py#n431

[Julie Pichon (jpichon)]

Hi Akihiro, thanks for following up on this. I've seen the auth_url concatenation error surface in Horizon before, so I made the assumption that the new neutronclient exception would be raised all the way to Horizon as well. If I'm mistaken, or the new exception inherits Unauthorized and is therefore already covered, then we can probably close this bug with no action required. Thanks!

[Launchpad Janitor (janitor)]

[Expired for OpenStack Dashboard (Horizon) because there has been no activity for 60 days.]