Unhandled UnboundLocalError in instance DetailView

[Brian DeHamer]

If an error is raised in the DetailView in openstack_dashboard.dashboards.project.instances.views) we assume that a redirect will be raised. However, certain exception classes will not result in a redirect when handled by the standard Horizon exception handler.

The problem spot is here (https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/views.py#L270). If the error handler doesn't raise a redirect, control will be returned to the statement after the 'except' block and the 'instance' variable may be unbound.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/79755

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/79755
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f680b741e205ecf883e2761873cc2c9e4043f896
Submitter: Jenkins
Branch: master

commit f680b741e205ecf883e2761873cc2c9e4043f896
Author: Brian DeHamer <email address hidden>
Date: Sat Feb 22 01:07:46 2014 -0800

    Fix unbound local error in instance DetailView

    If an error is raised in the instance DetailView we assume that a
    redirect will be raised. However, certain exception classes will not
    result in a redirect when handled by the standard Horizon exception
    handler. If the error handler doesn't re-raise some sort of error,
    control will be returned to the statement after the except block and
    some of the necessary local variables may be unbound.

    This fix simply ensures that an errors result in a redirect so that
    we never end-up in a situation where the instance variable is unbound.

    Change-Id: Ica9a09c9236bb50206277425633d63a8e7387401
    Closes-Bug: 1291021