Host Aggregate actions open up two different modals

[Cindy Lu]

Admin > Host Aggregates

If we open up "Create Host Aggregate" modal, we see 2 tabs: "Host Aggregate Info" and "Hosts within aggregate"

However, if we click on one of the table row's "Edit Host Aggregate", it opens up it's own modal form instead of the workflow tab.

The modal behavior here should match Admin > Project. "Create Project" and "Edit Project" both open the same tabbed modal window.

[Santiago Baldassin (santiago-b-baldassin)]

I do not agree. If the user wants to update the aggregate metadata then he/she can do it with the Edit option and if he/she wants to add or remove hosts from/to the aggregate then the Manage Host option should be used.

[Cindy Lu (clu-m)]

Hi Santiago,

The same thing happens in Admin > Project. It has an "Edit Project" and "Modify Users" - but they are using the same workflow modal. That is why I suggest this.

[Santiago Baldassin (santiago-b-baldassin)]

Hi Cindy, I got your point. What I do not agree about is that you need to use the same modal . In fact...I would change the projects modal to work the same way than the aggregates are working now

The aggregates creation has two steps:
* set the aggregate info (name and availability zone)
* add hosts to the aggregate

Once you created the aggregate you might want to just change the name, so there's no need to bother the user with an extra tab for the hosts. The same way, if you just want to add/remove hosts to the aggregate, there's no need to display the info tab.

My two cents :)

[Cindy Lu (clu-m)]

Hello again!

It just seems like the standard behavior right now. In Edit Instance as well. It seems like overhead if there are 3 tabs in the "Create _____" but then if you want to edit any one of them it opens up a new modal panel instead of using the existing modal.

Maybe someone can weigh in on this. :)

[Esperanza Romero (esperanza-romero)]

I think this is actually a bug. The behavior should be consistent among all windows.

[Julie Pichon (jpichon)]

I agree with Cindy and Esperanza, it seems more consistent to keep the same experience. The 2 actions should still be in the Actions menu and simply focus on a different tab. Thanks!

[Santiago Baldassin (santiago-b-baldassin)]

I'm ok with having a consistent experience that's why I suggested that we should change projects to work as aggregate is working now :)

The problem with using workflows with multiple steps is that we have to add some logic to understand which of the workflows steps have been updated by the user and act based on that. In this particular case for example, let's say we wanted to update the aggregate name, the workflow with the two tabs would be opened and the name will be updated.

Now in the workflow handle method we don't know if the user updated the aggregate info or the aggregate hosts or both. So we'll have to add some logic to determine what changed and all of this to let the user update the aggregate name :)

[Julie Pichon (jpichon)]

From a user experience perspective it still seems to be the best/least surprising solution, to me. I think we should work out the implementation details separately - perhaps implementing it with the existing workflow warts first, and fixing that kind of issues with "figuring out what changed" then on a larger scale, as that comes back regularly with both workflows and forms.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/109360

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/109360
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Masco (masco)]

removed the assignee since not active for long time.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/365539

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/365539
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.