enforce error check in Resource Usage Daily Report textfield

Bug #1288512 reported by Cindy Lu
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Matthias Runge

Bug Description

in the Daily Report tab in Resource Usage, the "Limit project count" field should enforce some type of error checking. If I enter some characters or decimal value instead of an integer and press generate report, it will give an django error.

Please see image

Revision history for this message
Cindy Lu (clu-m) wrote :
Revision history for this message
Rob Raymond (rob-raymond) wrote :

Hi Cindy

I was starting to fix this but I thought I would first check that you did not plan to.

Rob

Revision history for this message
Cindy Lu (clu-m) wrote :

Hi Rob,

I did not plan to. It's yours. :)

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/82908

Changed in horizon:
assignee: nobody → Rob Raymond (rob-raymond)
Changed in horizon:
assignee: Rob Raymond (rob-raymond) → nobody
Revision history for this message
Doug Fish (drfish) wrote :

This issue was rediscovered during a translation test. Typing in "二十" or "three" might seem reasonable but results in a needlessly ugly error page.

Julie Pichon (jpichon)
Changed in horizon:
status: In Progress → Confirmed
importance: Undecided → Medium
Doug Fish (drfish)
Changed in horizon:
assignee: nobody → Doug Fish (drfish)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/102003

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Doug Fish (drfish) wrote :

I'm surprised to see this marked as a duplicate. A;though it is on the same form as the date range problem, its a separate field. Is the scope of 1331427 going to be expanded to address this field also?

Revision history for this message
Julie Pichon (jpichon) wrote :

Looking at the descriptions, comment 7 makes sense to me - removing duplicate relationship.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Doug Fish (<email address hidden>) on branch: master
Review: https://review.openstack.org/102003
Reason: Made irrelevant by the refactor https://review.openstack.org/#/c/107011/

Changed in horizon:
assignee: Doug Fish (drfish) → Matthias Runge (mrunge)
Changed in horizon:
assignee: Matthias Runge (mrunge) → Nikunj Aggarwal (nikunj2512)
Changed in horizon:
assignee: Nikunj Aggarwal (nikunj2512) → Matthias Runge (mrunge)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/107011
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ca2e10c3e8efa6d5ae07a04ea0cd6a029dad7319
Submitter: Jenkins
Branch: master

commit ca2e10c3e8efa6d5ae07a04ea0cd6a029dad7319
Author: Matthias Runge <email address hidden>
Date: Tue Oct 14 11:26:42 2014 +0200

    Refactor metering dashboard

    - check date range for validity
    - use django forms
    - treat times according to users timezone

    Change-Id: I68182ddb4b00d19e54011722ebc770d9aa8e725c
    Closes-bug: #1331427
    Closes-bug: #1331434
    Closes-bug: #1288512

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.