| 2014-03-04 20:05:13 |
Julie Pichon |
description |
Initially Horizon only supported VNC. As support for new console types was added, the code was expanded for each console without necessarily looking at the whole, and now the code could use a bit of freshening up. This is particularly obvious in tabs.py.
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tabs.py#L55 |
Initially Horizon only supported VNC. As support for new console types was added, the code was expanded for each console without necessarily looking at the whole, and now the code could use a bit of freshening up. This is particularly obvious in tabs.py.
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tabs.py#L55
From a comment on https://review.openstack.org/#/c/44257/ :
"We should have a common Console class that's aware of the different types, and a common means of detecting which console type to use for the instance rather than the chain of try/except statements." |
|
