Selected instances are not deleted with pagination

Bug #1287093 reported by Abhishek Kekane
38
This bug affects 6 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Ankit Agrawal

Bug Description

Instance is not getting deleted from other than first page of pagination when pagination is enabled.

Steps to reproduce:

1. Login to horizon using admin credentials.
2. Click on settings menu.
3. In "User Settings" menu set "Items Per Page" count as 5 and click on "Save" button to save the settings.
4. Click on "Project" tab and select "admin" project.
5. Click on "Instances" menu.
6. On Instances page click on "Launch Instance" button to add instances.
7. Add 6 to 7 instances.
8. On the Instances page 5 instances will be displayed. Click on "More »" link at the bottom of Instances table.
9. On the second page select instance and delete it.
10. You will be redirected to 1st page and the selected instances from 2nd page will not get deleted.

Note:
If you delete the instances from 1st page then it will get deleted.

Changed in horizon:
assignee: nobody → Abhishek Kekane (abhishek-kekane)
Changed in horizon:
assignee: Abhishek Kekane (abhishek-kekane) → Ankit Agrawal (ankitagrawal)
summary: - Selected Instances are not deleted with pagination
+ Selected instances are not deleted with pagination
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77837

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/77837
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e95a04733d463658f3ca87e9df213b8e1dd0326d
Submitter: Jenkins
Branch: master

commit e95a04733d463658f3ca87e9df213b8e1dd0326d
Author: ankitagrawal <email address hidden>
Date: Tue Mar 4 02:05:02 2014 -0800

    Selected instances are not deleted with pagination

    Added get_full_url() method to get the absolute url
    with the marker object required for pagination and
    used it in form action with POST call on terminate
    instance.
    Overridden the get_full_url() method to encode the url
    for ContainersTable and ObjectsTable classes which
    inherits the DataTable class.

    Change-Id: Idcf09e2e42bdfcbe8eb6d9f554d653fd7143bf8c
    Closes-Bug: #1287093

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
Julie Pichon (jpichon) wrote :

This should be marked as "Fixed released" as it was part of Icehouse RC1 according to the tag on the github commit - https://github.com/openstack/horizon/commit/e95a04733d463658f3ca87e9df213b8e1dd0326d . I think the status wasn't changed because the "duplicates" relationship was the wrong way around

Changed in horizon:
importance: Undecided → High
status: Fix Committed → Fix Released
tags: added: havana-backport-potential
removed: ntt
Julie Pichon (jpichon)
Changed in horizon:
milestone: none → juno-1
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.1
Revision history for this message
Krzysztof Szafrański (k-p-szafranski) wrote :

There is an identical issue with deleting projects.

I don't know if this fix resolves that issue as well, so I'm not reporting a new bug for now.

Revision history for this message
Julie Pichon (jpichon) wrote :

I believe the patch fixed the issue for all tables, I cannot reproduce the problem on the projects table.

Revision history for this message
Jeffrey Zhang (jeffrey4l) wrote :

This bug is not backport to Havana. I create a patch to do this. Pls see

https://gist.github.com/jeffrey4l/b79624ea2f1fbfcdb0c9

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.