RouterNotFound not handled correctly

[Matthew D. Wood]

When a call to the neutronclient attempts to find a router that doesn't exist, the neutronclient returns a very generic NeutronClientException. This, in turn, isn't handled correctly within horizon.exceptions.handle; it's treated as a RECOVERABLE error instead of a NOT_FOUND error. Clearly, this is a bad thing, and redirects don't happen correctly and all manner of other bad things can happen.

I've opened up a bug against the neutronclient here:
https://bugs.launchpad.net/neutron/+bug/1284317

There's 2 solutions to this problem:

A) Fix the neutronclient code to actually have a RouterNotFoundClient exception (just like the NetworkNotFoundClient and PortNotFoundClient exceptions) and then add that to the appropriate bucket: openstack_dashboard.exceptions.NOT_FOUND . Clearly the downsides of this approach are that we have to wait for the neutron bug to be fixed, and then our code would then depend upon that fix.

B) Temp-fix things in the mean time.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76049

[Matthew D. Wood (woodm1979)]

The review has been abandoned for quite a long time. The quick-fix wasn't necessary.