volume name field doesn't repopulate

[Cindy Lu]

==Steps to reproduce==

1. Project > Instances > Create Snapshot for any instance so that you have at least one snapshot

2. Go to Project > Volumes > Create Volume

2. For Volume Source, select Image

3. In 'Use image as a source' make sure there are at least 2 choices. select any one.
     ==> You will notice that Volume name and size will automatically be populated

4. Now select another image source.
    ==> Volume name and size are not updated

Alternate instructions:
1. Go to Project > Instances > Create Volume
2. For Volume Source, select Image
3. For Use image as a source, make sure you have more than 1 choice
4. select one, notice that Volume name and size are auto-populated
5. now select another image as source
6. the 2 fields are not repopulated

[Justin Pomeroy (jpomero)]

Looking at the code I see that it currently works like this: The volume name is updated when selecting the image source only if the volume name is currently not set. The volume size is recalculated each time the selection changes, so in that case it's probable that the images you are selecting end up with the same volume size.

As for the volume name, I think the idea was probably that we don't want the name to be automatically replaced in case the user had already entered their own value.

[David Lyle (david-lyle)]

I think the name field is questionable but make an is_empty check before populating, the size field should certainly be updated.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76606

[OpenStack Infra (hudson-openstack)]

Change abandoned by Santiago Baldassin (<email address hidden>) on branch: master
Review: https://review.openstack.org/76606

[Ivan Kolodyazhny (e0ne)]

We have to check if it's still actual.