Neutron logged out TypeError

[Matthew D. Wood]

If a users's token is not valid, the neutron client will raise a

TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

This TypeError should really be an neutronclient.common.exceptions.Unauthorized instead.

The TypeError is a result of a neutron_client.Client having it's auth_url set to None; which, unfortunately, is the default.

This can be recreated by logging in, and opening up a 2nd tab/window. Logout in one window. In the other window, go to a page that requires a neutron-api call (the networking page comes to mind).

[Matthew D. Wood (woodm1979)]

It's worth noting: the fix is to pass in a correct auth_url, but know that the authenticate call that will use that auth_url WILL FAIL. (... because we don't keep the user's password.)

That's the correct behavior, and the failed authenticate() call will bubble up a neutronclient.common.exceptions.Unauthorized exception instead of a TypeError. That exception will be caught correctly higher up.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/73420

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73420
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d8bb6fe0952f38bc6b670b424501b96e4813df33
Submitter: Jenkins
Branch: master

commit d8bb6fe0952f38bc6b670b424501b96e4813df33
Author: woodm1979 <email address hidden>
Date: Thu Feb 13 14:27:23 2014 -0700

    1279979 Neutron TypeError when token invalid

    When a neutron api-call is made, if the user's token is invalid, the
    neutron client will return a type-error because no auth_url has been
    provided.

    TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

    This TypeError should really be an
    neutronclient.common.exceptions.Unauthorized instead, which will get
    percolated up via a password-base authentication failure.

    Change-Id: I284e5cdf943fc63faf8509fdbe3caa45179d5f71
    Closes-Bug: 1279979