Latest keystoneclient breaks tests

[Steven Hardy]

The new release of keystoneclient (0.6.0) introduces some new metaclass magic which breaks our mocking in master :(

We probably need to modify the test to use mock instead of mox, as the issue seems to be that mox misinterprets the class type due to the metaclass.

Immediate workaround while we workout the solution is probably to temporarily cap keystoneclient to 0.5.1 which did not have this issue.

Traceback (most recent call last):
  File "/home/shardy/git/heat/heat/tests/test_heatclient.py", line 449, in test_trust_init
    self._stubs_v3(method='trust')
  File "/home/shardy/git/heat/heat/tests/test_heatclient.py", line 83, in _stubs_v3
    self.m.StubOutClassWithMocks(kc_v3, "Client")
  File "/usr/lib/python2.7/site-packages/mox.py", line 366, in StubOutClassWithMocks
    raise TypeError('Given attr is not a Class. Use StubOutWithMock.')
TypeError: Given attr is not a Class. Use StubOutWithMock.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/73369

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/73410

[Steve Baker (steve-stevebaker)]

capping fails due to the requirements check https://jenkins02.openstack.org/job/gate-heat-requirements/219/console

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73410
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=043085f812a1d06e8e082b2dbd52f406172bbfff
Submitter: Jenkins
Branch: master

commit 043085f812a1d06e8e082b2dbd52f406172bbfff
Author: David Lyle <email address hidden>
Date: Thu Feb 13 13:57:22 2014 -0700

    Fixing tests to work with keystoneclient 0.6.0

    Another item needs mocking with the new release of
    python_keystoneclient. Adding it to mocked keystoneclient.Client
    object.

    Closes-Bug: #1279907
    Change-Id: I3c43a7290a6e05c718082dcad369162bf21e3603

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/73544

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/73562

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/73568

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73544
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=26fe7a961f644e1c93a92c8a73b25d649137f7b9
Submitter: Jenkins
Branch: master

commit 26fe7a961f644e1c93a92c8a73b25d649137f7b9
Author: Thomas Herve <email address hidden>
Date: Fri Feb 14 10:11:55 2014 +0100

    Fix incompatibilities in tests with keystoneclient 0.6

    The patch removes usage of StubOutClassWithMocks with keystone Client
    class, which doesn't work anymore now that there is an ABC in the MRO.

    Change-Id: I4e8ff2cde2723060faf9906ecf51b13911ac5f42
    Closes-Bug: #1279907

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/74129

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/74316

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/74316
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=cfd6b0207420f4322d8bbb0d2af348e7cdeeed03
Submitter: Jenkins
Branch: stable/havana

commit cfd6b0207420f4322d8bbb0d2af348e7cdeeed03
Author: Thomas Herve <email address hidden>
Date: Fri Feb 14 10:11:55 2014 +0100

    Fix incompatibilities in tests with keystoneclient 0.6

    The patch removes usage of StubOutClassWithMocks with keystone Client
    class, which doesn't work anymore now that there is an ABC in the MRO.

    Closes-Bug: #1279907
    (cherry picked from commit 26fe7a961f644e1c93a92c8a73b25d649137f7b9)

    Conflicts:
     heat/tests/test_heatclient.py

    Change-Id: I4e8ff2cde2723060faf9906ecf51b13911ac5f42

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73568
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e6a46534d08fe10fa71fd903aca9c87230667b18
Submitter: Jenkins
Branch: stable/grizzly

commit e6a46534d08fe10fa71fd903aca9c87230667b18
Author: David Lyle <email address hidden>
Date: Thu Feb 13 13:57:22 2014 -0700

    Fixing tests to work with keystoneclient 0.6.0

    Another item needs mocking with the new release of
    python_keystoneclient. Adding it to mocked keystoneclient.Client
    object.

    Closes-Bug: #1279907
    Change-Id: I3c43a7290a6e05c718082dcad369162bf21e3603
    (cherry picked from commit 043085f812a1d06e8e082b2dbd52f406172bbfff)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73562
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=82cb9f6f019fd3205ec736e1db77616447c0e890
Submitter: Jenkins
Branch: stable/havana

commit 82cb9f6f019fd3205ec736e1db77616447c0e890
Author: David Lyle <email address hidden>
Date: Thu Feb 13 13:57:22 2014 -0700

    Fixing tests to work with keystoneclient 0.6.0

    Another item needs mocking with the new release of
    python_keystoneclient. Adding it to mocked keystoneclient.Client
    object.

    Closes-Bug: #1279907
    Change-Id: I3c43a7290a6e05c718082dcad369162bf21e3603
    (cherry picked from commit 043085f812a1d06e8e082b2dbd52f406172bbfff)