No prev link in the instance list pagination

[Maithem]

When there are more than 20 instances, there is only a next button to see the next 20 instances, but there isn't a back button, so you cant see the last 20 instance.

[David Lyle (david-lyle)]

This is a limitation built into the nova api. And the way horizons tables currently support pagination. It is possible to improve, but is a non-trivial amount of work.

[Thai Tran (tqtran)]

While I agree that we should take advantage of paging API if it exists, I also think we should implement a paging mechanism on the front end. Fetch the data all in one-go along with a page_limit, then have the front-end render the table and take care of paging. In the future, when paging API for it exists, we can still continue to leverage that.

Some of the advantages are:
1. prevent browser from crashing when rendering large data set
2. improve user experience and easier to view
3. improve filtering (since it can now filter across entire data set and not just the page)
4. and arguably, prevent unnecessary traffic when paging (since we don't need to take additional API calls)

[Thai Tran (tqtran)]

Check this example out.
http://tablesorter.com/docs/example-pager.html

[Ladislav Smola (lsmola)]

Will offer this as part of internship program that starts soon, if nobody will pick it I will remove my assignment.

[Cindy Lu (clu-m)]

Hi all,

Back button will be possible once this blueprint goes through. It will provide sort_key and sort_dir.

https://blueprints.launchpad.net/nova/+spec/nova-pagination

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/160192
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Xav Paice (xavpaice)]

https://blueprints.launchpad.net/nova/+spec/nova-pagination appears to have gone through - is there any appetite to revive this?

[Ying Zuo (yingzuo)]

Another patch for fixing this issue: https://review.openstack.org/#/c/498018/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/517614

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/498018
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/160192
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/517614
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/498018
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=467669417979ec7443d5195d4b4635d5596cdc08
Submitter: Zuul
Branch: master

commit 467669417979ec7443d5195d4b4635d5596cdc08
Author: Ferenc Cserepkei <email address hidden>
Date: Fri Aug 25 19:53:42 2017 +0200

    Add "prev" link to instance page list pagination

    Currently there is no link to previous page at paginated instances
    table. This patch resolves that issue by re-using the pagination
    code for flavors.

    It also supports Ying Zuo's scenario:
    After I set only 1 item per page and deleted the instance on the first page,
    the expected behavior is showing the next instance in the table after one is
    deleted.

    xxxIndexView uses PagedTableMixin's _get_marker() from now instead of GET()-
    ing the markers

    Closes-Bug: #1274427
    Co-Authored-By: Dmitry Ratushnyy <email address hidden>
    Co-Authored-By: Akihiro Motoki <email address hidden>
    Change-Id: Id8eaae6bf1b5d6f42291291655e14b8715c08bc8
    Signed-off-by: Ferenc Cserepkei <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 15.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/695570

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/695570
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=44a098abcf287dfa67db6aede0d63dc58df80b07
Submitter: Zuul
Branch: stable/rocky

commit 44a098abcf287dfa67db6aede0d63dc58df80b07
Author: Ferenc Cserepkei <email address hidden>
Date: Fri Aug 25 19:53:42 2017 +0200

    Add "prev" link to instance page list pagination

    Currently there is no link to previous page at paginated instances
    table. This patch resolves that issue by re-using the pagination
    code for flavors.

    It also supports Ying Zuo's scenario:
    After I set only 1 item per page and deleted the instance on the first page,
    the expected behavior is showing the next instance in the table after one is
    deleted.

    xxxIndexView uses PagedTableMixin's _get_marker() from now instead of GET()-
    ing the markers

    Closes-Bug: #1274427
    Co-Authored-By: Dmitry Ratushnyy <email address hidden>
    Co-Authored-By: Akihiro Motoki <email address hidden>
    Change-Id: Id8eaae6bf1b5d6f42291291655e14b8715c08bc8
    Signed-off-by: Ferenc Cserepkei <email address hidden>
    (cherry picked from commit 467669417979ec7443d5195d4b4635d5596cdc08)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 14.1.0 release.