Tox failing on py27dj14 environment
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Medium
|
Peter Belanyi |
Bug Description
Full test log: http://
It seems like django.
Further inspection revealed that there is a difference in parsing between start tag and end tag and even more, difference between parsing tags with and without the attributes:
HTMLParser.
but
HTMLParser.
Somewhere between 2.7.3 and 2.7.4 Python had changed its HTMLParser.tagfind regex [1, 2]. Django relied heavily on this regex with its own _HtmlParser modification [3] and hadn't react fast enough to land the fix in 1.4 [4].
So what we are having here is for particular configuration including both python 2.7.4+ and django 1.4, django.
The question is what should we do in this case. Should we limit py27dj14 environment with basepython of 2.7.3, should we disable this tests on Django 1.4, replace the assertion function with one without the bug or just completely ignore that bug as irrelevant?
---
[1] http://
[2] http://
[3] https:/
[4] https:/
Changed in horizon: | |
assignee: | nobody → Peter Belanyi (pbelanyi) |
Changed in horizon: | |
milestone: | none → juno-1 |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | juno-1 → 2014.2 |
Thank you for the detailed report and digging into the cause! We'll want to keep the tests for Django 1.4 as long as we support that version. It looks like we're fine for the py27dj14 gating tests for now, because the nodes run Ubuntu Precise and that ships with 2.7.3 - but this isn't an ideal situation and we'll want to fix the tests or test environment somehow.