wizard broken in non modal view

Bug #1273608 reported by Yves-Gwenael Bourhis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Radomir Dopieralski

Bug Description

When creating a network we get a wizard view since https://review.openstack.org/#/c/64644/
However even with JS activated, after a login timeout the view is in non modal mode.
This non modal mode is also accessible directly via the URL http://<You_Horizon_Server>/project/networks/create

First issue:
========
In this mode, the form doesn't show as a wizard anymore but with tabs as before, but the "next" and "back" buttons are not functional.

Second issue:
==========
The required fields raise their error only after clicking the "create button" (and not when changing tab) as they should in wizard mode. (can be tested thoroughly with https://review.openstack.org/#/c/63078/ )

description: updated
Changed in horizon:
assignee: nobody → Radomir Dopieralski (thesheep)
Changed in horizon:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/69575

Changed in horizon:
status: Confirmed → In Progress
Julie Pichon (jpichon)
tags: added: icehouse-backport-potential
Changed in horizon:
importance: Undecided → Medium
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/69575
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=44ab36328878660a137767556c96bcf2cf9edb49
Submitter: Jenkins
Branch: master

commit 44ab36328878660a137767556c96bcf2cf9edb49
Author: Radomir Dopieralski <email address hidden>
Date: Tue Jan 28 11:54:03 2014 +0100

    Make wizard workflow work when non-modal

    The JavaScript code that adds the wizard functionality was initialized
    only when the page was displayed as a modal. I moved the call to that
    initialization function into the template, so that it is called always
    when a wizard is displayed.

    Change-Id: Id73116392158ea08b4f04062f4f926286b1f7973
    Closes: bug 1273608

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.