Checkboxes get displayed even if no table actions are available

Bug #1271194 reported by Julie Pichon
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Leandro Ignacio Costantino

Bug Description

Even if no table actions are available, checkboxes are displayed in the first column which can be confusing, since nothing can actually be done using them (see screenshot).

Example for how to reproduce:
1. As an admin, create a shared network
2. Create a subnet for it
3. From the Project dashboard, navigate to the Networks panel and select the new shared network that was created

Actual result:
4. The subnet is displayed, including a checkbox that doesn't serve any purpose

Expected result:
4. The subnet is displayed, no need for checkboxes if there is no action buttons for the table

Tags: ux
Revision history for this message
Julie Pichon (jpichon) wrote :
Revision history for this message
Leandro Ignacio Costantino (leandro-i-costantino) wrote :

Disregard last comment. I saw the wrong screen.
sorry

Changed in horizon:
status: New → Confirmed
Changed in horizon:
assignee: nobody → Leandro Ignacio Costantino (leandro-i-costantino)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/69243

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/69243
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0bf864eff4188b0e9e62a7e2e66599582a31d567
Submitter: Jenkins
Branch: master

commit 0bf864eff4188b0e9e62a7e2e66599582a31d567
Author: Leandro I. Costantino <email address hidden>
Date: Sun Jan 26 19:04:45 2014 -0500

    Hide column on multi_select tables if no actions available.

    This patch will add a runtime check to hide/show checkbox columns
    on multi_select tables.
    Right know the behaviour is calculated once but does not take in account
    the dynamic allowed call of each Table Action available.

    The change will add 'hidden' class to the first column if table actions
    are present but all of them returned False on allowed() call.

    Change-Id: Ia4512abe3dbb5de4581673717eb518b2d3a50291
    Closes-Bug: #1271194

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.