run_tests.sh compilemessages should remove English MO files

Bug #1261290 reported by Akihiro Motoki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

Django manage.py compilemessage comple message catalogs of all languages including English (source language) by default and there is no way to exclude a specific language. English is a source language in Horizon and there is no need to have compiled message catalog (MO files) for English. After running run_tests.sh --compilemessages, we always have unnecessary English MO files and we need to remove it manually every time :-(
run_tests.sh --compilemessages should remove English MO files.

For long term solution, it seems better to add an option to exclude a specific language to "./manage.py compilemessages".

Changed in horizon:
assignee: nobody → Ana Krivokapić (akrivoka)
Changed in horizon:
status: New → Incomplete
status: Incomplete → Confirmed
Revision history for this message
Julie Pichon (jpichon) wrote :
Changed in horizon:
status: Confirmed → In Progress
Changed in horizon:
assignee: Ana Krivokapić (akrivoka) → Akihiro Motoki (amotoki)
David Lyle (david-lyle)
Changed in horizon:
milestone: none → icehouse-rc1
milestone: icehouse-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/82268
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c3a6c79ebbf808e65ea3037acdf8247d3992ef9e
Submitter: Jenkins
Branch: master

commit c3a6c79ebbf808e65ea3037acdf8247d3992ef9e
Author: Akihiro Motoki <email address hidden>
Date: Sat Mar 22 10:11:10 2014 +0900

    Remove English compiled catalogs after compilemessages

    ./run_tests.sh --compilemessages compiles all languages including
    English, but English is the source language and there is no need
    to have compiled message catalogs for English.

    Also this commit update the description of --makemessages.

    Change-Id: I30cf4336cc796e8e3bea71120b6c75ce40aaf888
    Closes-Bug: #1261290

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
Ana Krivokapić (akrivoka) wrote :

FYI, I submitted a pull request implementing the option to exclude a specific language to upstream Django:

https://github.com/django/django/pull/2472

Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
Revision history for this message
Ana Krivokapić (akrivoka) wrote :

FYI, my patch implementing --exclude option for makemessages and compilemessages was merged to Django and will be included in the 1.8 release.

https://github.com/django/django/commit/0707b824fe77e08ca8b75fcc3738ada694f2a3a6

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.