Images table isn't enable pagination on Project Panel

Bug #1252649 reported by Zhenguo Niu
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Timur Sufiev

Bug Description

On Project dashboard, Images table displays all items on one page, we should enable pagination here.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/57885

Changed in horizon:
assignee: nobody → chenhaiq (chenhaiq)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/58928

Revision history for this message
Cindy Lu (clu-m) wrote :

This patch should be restored. :)

Revision history for this message
Cindy Lu (clu-m) wrote :

Hey chenhaiq,

Any update on this?

The patch is good, just needs a rebase. :)

Thanks!!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/58928
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/207812

Changed in horizon:
assignee: chenhaiq (chenhaiq) → Timur Sufiev (tsufiev-x)
Revision history for this message
Timur Sufiev (tsufiev-x) wrote :

Let's finish this bug!

Changed in horizon:
assignee: Timur Sufiev (tsufiev-x) → Lucas Palm (lapalm)
Timur Sufiev (tsufiev-x)
Changed in horizon:
assignee: Lucas Palm (lapalm) → Timur Sufiev (tsufiev-x)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/207812
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0f7f17c62a88152e2a2ffb383799d5e929260bf6
Submitter: Jenkins
Branch: master

commit 0f7f17c62a88152e2a2ffb383799d5e929260bf6
Author: chenhaiq <email address hidden>
Date: Thu Jun 12 13:42:53 2014 +0800

    Enable pagination for Project->Images view

    This feature is already implemented, but not enabled because it
    has strange behavior when the image list is filtered by removing aki
    and ari type of images.

    The pagination for images view should be enabled since the filtering
    image code was removed in: https://review.openstack.org/#/c/59935/

    Because the ImagesTable is the only one being incorporated into the
    images view, there is no need to include table.name attribute into
    _prev and _more attributes of the view (no other tables to distinguish
    between).

    This is a refreshment of https://review.openstack.org/#/c/58928/
    (which I cannot update because it's abandoned).

    Change-Id: Ib027a548ee8aa623f0faea86f0ad7570d6ec2360
    Co-Authored-By: chenhaiq <email address hidden>
    Closes-Bug: #1252649

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → High
milestone: none → mitaka-1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b1

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

Changed in horizon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.