when creating instance,access security and networking tabs missing asterisk

[Ami Jeain]

when creating an instance, only the Details tab has asterisk, although security group and network is mandatory, therefore should also include asterisk

[David Lyle (david-lyle)]

Actually only the network tab is required, but it is missing an asterisk.

[Ami Jeain (ajeain)]

I believe that also the security group should have asterisk, as if you omit the "default" security group, you get an error message saying "This field is required". You can confirm that if you look next to the Security Groups text, you will see the asterisk, which means that the whole window should have one too.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/59944

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/59949

[David Lyle (david-lyle)]

The proposed review has been abandoned. By oversight, a second review was posted by a different author that fixes the underlying problem elegantly, https://review.openstack.org/#/c/61530/ which points to a duplicate bug.

[David Lyle (david-lyle)]

You are correct about the security group requirement. My oversight.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/61891

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/61530
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=788ec08c4f3e53b1f3dbaa40c19a0a71c21cdf42
Submitter: Jenkins
Branch: master

commit 788ec08c4f3e53b1f3dbaa40c19a0a71c21cdf42
Author: Matthew Wood <email address hidden>
Date: Wed Dec 11 11:30:28 2013 -0700

    Bad workflow-steps check: has_required_fields

    Many of the tabs on the Instance Creation screen don't show a "*"
    despite having require fields. This is due to faulty logic in determining
    whether the workflow-step has require fields. (Previously, only keys from
    the contributes list were checked.)

    Change-Id: Id609da27c51f8d4725683d7fd1534ead0c3bb984
    Closes-Bug: 1252005

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/67076

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/67076
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ce8611c3dc053c331170a9e6cc9813f9d6e4c756
Submitter: Jenkins
Branch: stable/havana

commit ce8611c3dc053c331170a9e6cc9813f9d6e4c756
Author: Matthew Wood <email address hidden>
Date: Wed Dec 11 11:30:28 2013 -0700

    Bad workflow-steps check: has_required_fields

    Many of the tabs on the Instance Creation screen don't show a "*"
    despite having require fields. This is due to faulty logic in determining
    whether the workflow-step has require fields. (Previously, only keys from
    the contributes list were checked.)

    Closes-Bug: 1252005

    Change-Id: Id609da27c51f8d4725683d7fd1534ead0c3bb984
    (cherry picked from commit 788ec08c4f3e53b1f3dbaa40c19a0a71c21cdf42)