Cannot see confirmation message when working on longer pages

Bug #1251361 reported by Julie Pichon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Facundo Maldonado
Havana
Fix Released
Medium
Akihiro Motoki

Bug Description

If you have a long list of e.g. Volumes and Snapshots and try to perform a "dangerous" action like Delete from the bottom of the page, the confirmation modal will appear outside of the visible screen at the top of the page, causing confusion for the user who suddenly gets "stuck". Attaching a screenshot as an example.

I think we should focus on the modal when it appears.

Tags: ux
Revision history for this message
Julie Pichon (jpichon) wrote :
Akihiro Motoki (amotoki)
Changed in horizon:
importance: Low → Medium
status: New → Confirmed
Revision history for this message
Facundo Maldonado (facundo-n-maldonado) wrote :

ok in chrome
occurs in Firefox
to be tested in other browsers

Changed in horizon:
assignee: nobody → Facundo Maldonado (facundo-n-maldonado)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60567

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/61491

Revision history for this message
Akihiro Motoki (amotoki) wrote :

IMO it is worth backport to havana.

tags: added: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/60567
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8950b90d1777e265f98379098cebef7517642efe
Submitter: Jenkins
Branch: master

commit 8950b90d1777e265f98379098cebef7517642efe
Author: Facundo Maldonado <email address hidden>
Date: Wed Dec 11 13:56:18 2013 -0300

    Change how scrollShift is calculated.

        In Firefox $('body').scrollTop returns 0, that's why the modal
        appear outside the visible screen. Added $('hmtl).scrollTop.

        var scrollShift = $('body').scrollTop() || $('html').scrollTop()

        Closes-Bug: 1251361

    Change-Id: Icf691eb140e091615a98f1fbd415428cd418ba9e

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/63380

Akihiro Motoki (amotoki)
tags: removed: havana-backport-potential
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/havana)

Reviewed: https://review.openstack.org/63380
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0aff703f9824cefd0c2fd8221bd2295e952699bb
Submitter: Jenkins
Branch: stable/havana

commit 0aff703f9824cefd0c2fd8221bd2295e952699bb
Author: Facundo Maldonado <email address hidden>
Date: Wed Dec 11 13:56:18 2013 -0300

    Change how scrollShift is calculated

    In Firefox $('body').scrollTop returns 0, that's why the modal
    appear outside the visible screen. Added $('hmtl).scrollTop.

    var scrollShift = $('body').scrollTop() || $('html').scrollTop()

    Closes-Bug: 1251361

    Change-Id: Icf691eb140e091615a98f1fbd415428cd418ba9e
    (cherry picked from commit 8950b90d1777e265f98379098cebef7517642efe)

Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.