run_tests.sh fails with a fresh venv due to django 1.6 installed

Bug #1250581 reported by Akihiro Motoki on 2013-11-12
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
High
Akihiro Motoki
Havana
High
Akihiro Motoki

Bug Description

Today when i removed the existing vnev and ran run_tests.sh, run_tests.sh failed.
run_tests.sh creates a fresh venv.

I found Django 1.6 is installed. it seems django-nose dependencies installs django-1.6.
It happens when we run "pip install -r requirements.txt" and then run "pip install -r test-requirements.txt" with --upgrade option. Horizon tools/install_venv_common is old and it seems to do so.

In the recent tools/install_venv_common both requirements files are evaluated at the same time and it looks the right solution. Updating them to new version (from oslo) addresses this issue.

Akihiro Motoki (amotoki) on 2013-11-12
description: updated

Fix proposed to branch: master
Review: https://review.openstack.org/56078

Changed in horizon:
status: New → In Progress

It affects havana too.

tags: added: havana-backport-potential
David Lyle (david-lyle) on 2013-11-13
Changed in horizon:
milestone: none → icehouse-1
Akihiro Motoki (amotoki) on 2013-11-14
summary: - run_tests.sh fails with a fresh venv
+ run_tests.sh fails with a fresh venv due to django 1.6 installed

Reviewed: https://review.openstack.org/56078
Committed: http://github.com/openstack/horizon/commit/7a0581bb701dbb4d7d9fb1bbe1d7644e98ac2b2e
Submitter: Jenkins
Branch: master

commit 7a0581bb701dbb4d7d9fb1bbe1d7644e98ac2b2e
Author: Akihiro MOTOKI <email address hidden>
Date: Wed Nov 13 03:30:42 2013 +0900

    Import install_venv from oslo

    The new version of install_venv_common evaluates requirements.txt
    and test-requirements.txt at the same time and we avoid Django 1.6
    is installed when evaluating django-nose dependencies.

    Change-Id: I2ab7108b3615ac6c0525089b81b80e5c0a4793fc
    Closes-Bug: #1250581

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki) on 2013-12-03
tags: removed: havana-backport-potential
Thierry Carrez (ttx) on 2013-12-04
Changed in horizon:
status: Fix Committed → Fix Released

Reviewed: https://review.openstack.org/56822
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=28749792fbc0eff009773dcd240849a5d4a3e052
Submitter: Jenkins
Branch: stable/havana

commit 28749792fbc0eff009773dcd240849a5d4a3e052
Author: Akihiro MOTOKI <email address hidden>
Date: Wed Nov 13 03:30:42 2013 +0900

    Import install_venv from oslo

    The new version of install_venv_common evaluates requirements.txt
    and test-requirements.txt at the same time and we avoid Django 1.6
    is installed when evaluating django-nose dependencies.

    Change-Id: I2ab7108b3615ac6c0525089b81b80e5c0a4793fc
    Closes-Bug: #1250581
    (cherry picked from commit 7a0581bb701dbb4d7d9fb1bbe1d7644e98ac2b2e)

Thierry Carrez (ttx) on 2014-04-17
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers