resource usage line chart categorical colors insufficiently contrasty

Bug #1243747 reported by Eoghan Glynn
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Sayali Lunkad

Bug Description

The line charts use d3.scale.category20() to allocate colors to the per-tenant trend lines.

However these colors are arranged in alternating dark-light pairs (darker blue, lighter blue, darker orange, lighter orange, ...):

  https://github.com/mbostock/d3/wiki/Ordinal-Scales#wiki-category20

The result is that as new tenants are created, the color rendered for every second new tenant is hard to distinguish visually from the previous one.

The resource usage panel should instead either use the narrower but more contrasty d3.scale.category10():

  https://github.com/mbostock/d3/wiki/Ordinal-Scales#wiki-category10

or else construct it's own wider and more contrasty ordinal scale.

Eoghan Glynn (eglynn)
tags: added: metering-ui
Revision history for this message
Eoghan Glynn (eglynn) wrote :
Revision history for this message
Ladislav Smola (lsmola) wrote :

agree

Changed in horizon:
status: New → Confirmed
tags: added: low-hanging-fruit
Changed in horizon:
assignee: nobody → Sayali Lunkad (sayali-92720)
Changed in horizon:
status: Confirmed → In Progress
Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/54890

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/54890
Committed: http://github.com/openstack/horizon/commit/59266cba1953d51b4eca80560c8d1568b1d8dd14
Submitter: Jenkins
Branch: master

commit 59266cba1953d51b4eca80560c8d1568b1d8dd14
Author: sayalilunkad <email address hidden>
Date: Fri Nov 1 14:31:28 2013 +0530

    Presents color contrast in resource usage charts

    This makes use of d3.scale.category10() to allocate colors to per tenant
    trend lines as opposed to d3.scale.category20().
    This makes it easy to distinguish the color rendered for each new tenant as
    d3.scale.category10() is a more contrasty.

    Closes-Bug: #1243747

    Change-Id: I6ac2bcd4fa831944dfb10944eb620d333e1f3644

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.