./templates/base.html.c:6: warning: unterminated string literal

Bug #1243526 reported by YangLei
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki
Havana
Fix Released
Medium
Akihiro Motoki

Bug Description

yanglei@yanglei-ThinkCentre-M58:~/community/horizon$ ./run_tests.sh --makemessages -N
horizon: /home/yanglei/installed_openstack_devstack/pbr/pbr/version.py:21: UserWarning: Module openstack_dashboard was already imported from /home/yanglei/community/horizon/openstack_dashboard/__init__.pyc, but /home/yanglei/installed_openstack_devstack/horizon is being added to sys.path
  import pkg_resources
WARNING:root:No local_settings file found.
processing language en
horizon javascript: /home/yanglei/installed_openstack_devstack/pbr/pbr/version.py:21: UserWarning: Module openstack_dashboard was already imported from /home/yanglei/community/horizon/openstack_dashboard/__init__.pyc, but /home/yanglei/installed_openstack_devstack/horizon is being added to sys.path
  import pkg_resources
WARNING:root:No local_settings file found.
processing language en
Error: errors happened while running xgettext on base.html
./templates/base.html.c:6: warning: unterminated string literal

yanglei@yanglei-ThinkCentre-M58:~/community/horizon$ git branch
* master
yanglei@yanglei-ThinkCentre-M58:~/community/horizon$

Revision history for this message
Radomir Dopieralski (deshipu) wrote :

Where did you get that base.html.c file from? It's not in horizon's repository.

Revision history for this message
YangLei (yanglyy) wrote :

Yes, I can not find "base.html.c" too.

yanglei@yanglei-ThinkCentre-M58:~/community/test2_horizon$ git clone https://github.com/openstack/horizon.git
Cloning into 'horizon'...
remote: Counting objects: 38257, done.
remote: Compressing objects: 100% (13808/13808), done.
remote: Total 38257 (delta 26561), reused 33382 (delta 22284)
Receiving objects: 100% (38257/38257), 10.81 MiB | 765 KiB/s, done.
Resolving deltas: 100% (26561/26561), done.
yanglei@yanglei-ThinkCentre-M58:~/community/test2_horizon$
yanglei@yanglei-ThinkCentre-M58:~/community/test2_horizon$ cd horizon/
yanglei@yanglei-ThinkCentre-M58:~/community/test2_horizon/horizon$ ./run_tests.sh --makemessages -N
horizon: /home/yanglei/installed_openstack_devstack/pbr/pbr/version.py:21: UserWarning: Module openstack_dashboard was already imported from /home/yanglei/community/test2_horizon/horizon/openstack_dashboard/__init__.py, but /home/yanglei/installed_openstack_devstack/horizon is being added to sys.path
  import pkg_resources
WARNING:root:No local_settings file found.
processing language en
horizon javascript: /home/yanglei/installed_openstack_devstack/pbr/pbr/version.py:21: UserWarning: Module openstack_dashboard was already imported from /home/yanglei/community/test2_horizon/horizon/openstack_dashboard/__init__.pyc, but /home/yanglei/installed_openstack_devstack/horizon is being added to sys.path
  import pkg_resources
WARNING:root:No local_settings file found.
processing language en
Error: errors happened while running xgettext on base.html
./templates/base.html.c:6: warning: unterminated string literal

yanglei@yanglei-ThinkCentre-M58:~/community/test2_horizon/horizon$ find . -type f | grep "base.html"
./horizon/conf/dash_template/templates/dash_name/base.html
./horizon/templates/horizon/common/_workflow_base.html
./horizon/templates/base.html
./horizon/test/test_dashboards/dogs/templates/dogs/base.html
./horizon/test/test_dashboards/cats/templates/cats/base.html
yanglei@yanglei-ThinkCentre-M58:~/community/test2_horizon/horizon$ find . -type f | grep "base.html.c"
yanglei@yanglei-ThinkCentre-M58:~/community/test2_horizon/horizon$

Revision history for this message
Akihiro Motoki (amotoki) wrote :

It is caused by the following commit:

commit 0b03a7fdea3d6586ec2c22783e309bb75d68fdc5
Author: Lei Zhang <email address hidden>
Date: Mon Oct 14 22:00:34 2013 +0800

    Add extra extension file to makemessage command line

    specify the file extensions of the makemessage to *.html, *.txt, *.csv

    Closes-Bug: #1226910
    Change-Id: I115cd448249ac0b1b27a6b28fca3f16d6b2670a6

Changed in horizon:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Akihiro Motoki (amotoki)
milestone: none → icehouse-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/53709

Changed in horizon:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/53709
Committed: http://github.com/openstack/horizon/commit/79ae2139bb2f458de698aa116270428f54e22dc6
Submitter: Jenkins
Branch: master

commit 79ae2139bb2f458de698aa116270428f54e22dc6
Author: Akihiro MOTOKI <email address hidden>
Date: Fri Oct 25 03:19:24 2013 +0900

    Fix warning in run_tests.sh --makemessages

    Specify --extension=html,txt,csv only for openstack_dashboard.
    For djangojs, --extension should be 'js'.
    This is the cause of the warning.

    Change-Id: Ia5ac03fa82c18356b8d210005f8696ae148981bd
    Closes-Bug: #1243526

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/59916

Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/havana)

Reviewed: https://review.openstack.org/59916
Committed: http://github.com/openstack/horizon/commit/06e78a8bd7c7d3d777c152230f9b8c88d2dd0487
Submitter: Jenkins
Branch: stable/havana

commit 06e78a8bd7c7d3d777c152230f9b8c88d2dd0487
Author: Akihiro Motoki <email address hidden>
Date: Tue Dec 3 23:56:48 2013 +0900

    Add extra extension file to makemessage command line

    specify the file extensions of the makemessage to *.html, *.txt, *.csv

    Closes-Bug: #1226910
    (cherry picked from commit 0b03a7fdea3d6586ec2c22783e309bb75d68fdc5)

    The above fix introduces an extra bug when updating POT files, so
    the commit below is also cherry-picked.
    ----
    Fix warning in run_tests.sh --makemessages

    Specify --extension=html,txt,csv only for openstack_dashboard.
    For djangojs, --extension should be 'js'.
    This is the cause of the warning.

    Closes-Bug: #1243526
    (cherry picked from commit 79ae2139bb2f458de698aa116270428f54e22dc6)
    ----

    This patch does not update POT files for stable/havana.
    They will be updated in a single patch.

    Change-Id: I115cd448249ac0b1b27a6b28fca3f16d6b2670a6

Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.