Orchestration: In-progress bar shown despite deletion complete

[Sandro Mathys]

With Heat, deleted stacks stick around for a while, in status DELETE_COMPLETE. Now in Horizon, the status is correctly shown as "Delete Complete", but in front of it the in-progress bar is always (and forever) shown. It should only be shown while deletion is actually in progress.

[Sandro Mathys (red-trela)]

So it seems the issue is actually that Heat is still listing the stacks that are in DELETE_COMPLETE status in a rarely seen bug. Usually, stacks with that status should not be listed anymore, so Horizon should _probably_ never get into this situation.

You might want to make sure with the Heat team that there are absolutely no cases where deleted stacks are ever listed and if so, ignore this issue and close the bug. Or handle the case just to be sure.

[Leandro Ignacio Costantino (leandro-i-costantino)]

This is still happening. I will propose a fix to handle this case.

[Leandro Ignacio Costantino (leandro-i-costantino)]

Current status screenshot

[Leandro Ignacio Costantino (leandro-i-costantino)]

Fix applied

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/69131

[Leandro Ignacio Costantino (leandro-i-costantino)]

Additional Note:

 if the stack is DELETE_COMPLETE it won't be listed anymore. But, if using the stack id to retrieve the information as the Ajax Update Row is doing right know the information is still available.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/69131
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a541f954a4c53c09fdccd32cb68e52ffc39fe2d0
Submitter: Jenkins
Branch: master

commit a541f954a4c53c09fdccd32cb68e52ffc39fe2d0
Author: Leandro I. Costantino <email address hidden>
Date: Sat Jan 25 10:13:38 2014 -0500

    Remove delete action and bar when stack is DELETE_COMPLETE.

    Heat is returning stack in DELETE_COMPLETE status. Beside that
    the table don't consider DELETE_COMPLETE status so the animation is
    always visible after deletion.

    As a side effect, the checkbox and delete (row action) button are enabled.

    This patch will remove the animation on DELETE_COMPLETE state and
    disable 'Delete' button and checkbox so it cannot be delete again
    by Table Delete action.

    Change-Id: Id9c8d34c99a4079d2afa7438353490bfaf91072b
    Closes-Bug: #1243087