i18n: "Filter" in "Flavor Access" tab of "Create Flavor" workflow is not translatable

[Akihiro Motoki]

"Flavor Access" tab of "Create Flavor" form in the Admin dashboard has small search windows in "All Projects" and "Selected Projects" repectively. The string "Filter" in the search windows are not translatable.

[Julie Pichon (jpichon)]

This applies to all workflows that use the "Update members" widget. The default value for the field needs to be marked translatable.

https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_workflow_step_update_members.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/51832

[Pavel Sviderski (spyyy)]

Review: https://review.openstack.org/51832

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/51832
Committed: http://github.com/openstack/horizon/commit/3b79ec17b710000fa00523774ed2eff7dc1c12ca
Submitter: Jenkins
Branch: master

commit 3b79ec17b710000fa00523774ed2eff7dc1c12ca
Author: Pavel Sviderski <email address hidden>
Date: Tue Oct 15 15:49:27 2013 +0400

    Fix incomplete translation of "Update members" widget

    Marks the default value for the search fields of the "Update members"
    widget translatable. Also updates the English PO file accordingly.

    Change-Id: I8c317de49087b4207bcb774dd241fd1e4591882b
    Closes-Bug: #1239927

[Łukasz Jernaś (deejay1)]

This should be easily merged into stable/havana as it doesn't result in any new strings

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/58101

[Ying Chun Guo (daisy-ycguo)]

Hi,

The same error happens in two filter components in the dialog of "Flavor Access". You can go to the dialog by clicking Admin->Flavors->Create Flavor->Flavor Access.

Can it be fixed in same patch?

Daisy

[Ying Chun Guo (daisy-ycguo)]

Hi,

The same error happens:
Two filter components in the dialog of "Project Members" by clicking Admin->Projects->Modify Users->Project Members.
Two filter components in the dialog of "Project Groups" by clicking Admin->Projects->Modify Users->Project Groups.
Two filter components in the dialog of "Domain Groups" by clicking Domains->Modify Groups->Domain Groups.

Can them be fix in the same patch?

Daisy

[Akihiro Motoki (amotoki)]

I believe they have been fixed in master.
Aren't they fixed in master? If so, please share more detail on how to reproduce.

[Akihiro Motoki (amotoki)]

My comment #9 is a response to Daisy's comments #7 and #8.
I confirmed it is fixed in the master branch.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/58101
Committed: http://github.com/openstack/horizon/commit/ac1eb599fed6f11a06c95f268bc61375273ca0ff
Submitter: Jenkins
Branch: stable/havana

commit ac1eb599fed6f11a06c95f268bc61375273ca0ff
Author: Pavel Sviderski <email address hidden>
Date: Tue Oct 15 15:49:27 2013 +0400

    Fix incomplete translation of "Update members" widget

    Marks the default value for the search fields of the "Update members"
    widget translatable. Also updates the English PO file accordingly.

    Change-Id: I8c317de49087b4207bcb774dd241fd1e4591882b
    Closes-Bug: #1239927
    (cherry picked from commit 3b79ec17b710000fa00523774ed2eff7dc1c12ca)