Create volume snapshot action should check quotas

Bug #1236711 reported by Kieran Spear
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Medium
Unassigned

Bug Description

Currently there's no quota check when creating a snapshot from a volume. We should do something similar to the CreateVolume action, which disables the button if the action is bound to fail due to quota.

The relevant cinder quotas are:

snapshots
gigabytes (if cinder is configured to include snapshot size in overall gigabytes quota)

Changed in horizon:
importance: Undecided → Medium
milestone: none → icehouse-1
status: New → Confirmed
Changed in horizon:
assignee: nobody → Romain Hardouin (romain-hardouin)
Changed in horizon:
status: Confirmed → In Progress
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → icehouse-2
David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-2 → icehouse-3
Revision history for this message
Mike Perez (thingee) wrote :

Spoke with Romain before grabbing this.

Changed in horizon:
assignee: Romain Hardouin (romain-hardouin) → Mike Perez (thingee)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/75442

Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → next
milestone: next → icehouse-rc1
David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-rc1 → next
Revision history for this message
Mike Perez (thingee) wrote :

I'm not sure if this is needed anymore. I just noticed the button is hidden if you're already over quota. If someone did something sneaky, I wouldn't care if they got a generic error.

Mike Perez (thingee)
Changed in horizon:
status: In Progress → Incomplete
assignee: Mike Perez (thingee) → nobody
Revision history for this message
Justin Pomeroy (jpomero) wrote :

As noted above, I don't think this is an issue anymore. The cinder limits are being checked to determine if the maxTotalSnapshots has been reached. It doesn't look like there is a check for total gigabyte usage though, so it's possible that should still be added, if there is even a way to determine if cinder is configured to include snapshot size in overall gigabytes quota.

Changed in horizon:
status: Incomplete → Invalid
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: next → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.