Create Project: Unable to retrieve default quota values

Bug #1235053 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Akihiro Motoki

Bug Description

In Quota tab in Create Project form, an error message "Unable to retrieve default quota values." is displayed just after opening a "Create Project" form.

This bug is introduced by commit c44552fe6634620ec8222591028ad93b0d9be746
(Retrieve security group quotas from Neutron if enabled) by me.

It changed the type of the returned value from QuotaSet to a list by mistake.
As a result, get method is not defined in quota_defaults and the above error occurs at:
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/projects/views.py#L135

It seems I was a bit confused.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49961

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/49961
Committed: http://github.com/openstack/horizon/commit/9fa87dad193f0324762b684ab08ecb8dfc6ce1cc
Submitter: Jenkins
Branch: master

commit 9fa87dad193f0324762b684ab08ecb8dfc6ce1cc
Author: Akihiro MOTOKI <email address hidden>
Date: Sun Oct 6 18:27:32 2013 +0900

    Fix a issue on retrieving default quota in Create Project

    quota names for security group are different between nova and neutron,
    so the same appoach can be used for floating IP. This commit reverts
    the change in get_default_quota_data in commit c44552fe66 and changes
    get_disabled_quotas to determine security group and rules quotas come
    from nova or neutron.

    Change-Id: I9e39ac99f1e8c7ccdce64b2e2ab79615cac50892
    Closes-Bug: #1235053

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → havana-rc2
tags: removed: havana-rc-potential
Changed in horizon:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/50584

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (milestone-proposed)

Reviewed: https://review.openstack.org/50584
Committed: http://github.com/openstack/horizon/commit/27873f7c8c14525b5467da400cdf93e252b6ab73
Submitter: Jenkins
Branch: milestone-proposed

commit 27873f7c8c14525b5467da400cdf93e252b6ab73
Author: Akihiro MOTOKI <email address hidden>
Date: Sun Oct 6 18:27:32 2013 +0900

    Fix a issue on retrieving default quota in Create Project

    quota names for security group are different between nova and neutron,
    so the same appoach can be used for floating IP. This commit reverts
    the change in get_default_quota_data in commit c44552fe66 and changes
    get_disabled_quotas to determine security group and rules quotas come
    from nova or neutron.

    Change-Id: I9e39ac99f1e8c7ccdce64b2e2ab79615cac50892
    Closes-Bug: #1235053
    (cherry picked from commit 9fa87dad193f0324762b684ab08ecb8dfc6ce1cc)

Thierry Carrez (ttx)
Changed in horizon:
status: In Progress → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.