Code cleanup/refactoring in "router" dashboard

[Abishek Subramanian]

Based on initial code review comments, there is scope for some code cleanup and refactoring of repeated methods in the new "router" dashboard. Additionally some redundant template files can be removed in this dashboard.

[Akihiro Motoki (amotoki)]

Refactoring should be deferred to Icehouse so i removed havana-rc-potential.

[Facundo Farias (facundo-farias)]

Hi Abishek, do you have any updates on this? Thanks!

[Abishek Subramanian (absubram)]

Hi,

A lot of the review comments are being fixed via separate bugs already
assigned to me.
This bug however will be targeted for J now. Some of the cleanup is not
being fixed in I right now.

Thanks!

On 3/11/14 2:22 PM, "Facundo Farias" <email address hidden> wrote:

>Hi Abishek, do you have any updates on this? Thanks!
>
>--
>You received this bug notification because you are subscribed to the bug
>report.
>https://bugs.launchpad.net/bugs/1229820
>
>Title:
> Code cleanup/refactoring in "router" dashboard
>
>Status in OpenStack Dashboard (Horizon):
> Confirmed
>
>Bug description:
> Based on initial code review comments, there is scope for some code
> cleanup and refactoring of repeated methods in the new "router"
> dashboard. Additionally some redundant template files can be removed
> in this dashboard.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/horizon/+bug/1229820/+subscriptions

[Abishek Subramanian (absubram)]

Please change target to J. Will work on fixing this asap in Juno.

[Akihiro Motoki (amotoki)]

Abishek, I retargeted this bug to Juno ("next" at now).

[Abishek Subramanian (absubram)]

Thanks Akihiro!

On 3/16/14 11:31 AM, "Akihiro Motoki" <email address hidden> wrote:

>Abishek, I retargeted this bug to Juno ("next" at now).
>
>** Changed in: horizon
> Milestone: icehouse-rc1 => next
>
>--
>You received this bug notification because you are subscribed to the bug
>report.
>https://bugs.launchpad.net/bugs/1229820
>
>Title:
> Code cleanup/refactoring in "router" dashboard
>
>Status in OpenStack Dashboard (Horizon):
> Confirmed
>
>Bug description:
> Based on initial code review comments, there is scope for some code
> cleanup and refactoring of repeated methods in the new "router"
> dashboard. Additionally some redundant template files can be removed
> in this dashboard.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/horizon/+bug/1229820/+subscriptions

[Facundo Farias (facundo-farias)]

Thanks Abishek. Do you have an open review for this issue?