Unit Test fixes with the new "router" dashboard

[Abishek Subramanian]

Currently the new dashboard "router" doesn't have its unit test run by default. This needs to be fixed.
Additionally, many existing unit tests such as the network create tests from the "project" and "admin" dashboards and also the instance create tests have been changed to accommodate the cisco n1k plugin only when the plugin is being used. The existing solution is very cumbersome with a check being done to test the config variable in the local_settings. A better solution needs to be found to ensure these are run in a better manner.

[Abishek Subramanian (absubram)]

Please set this target to J. Will work on getting this fixed first thing in Juno.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/90093

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/90093
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2f2312dfcccda1b421a80f27e6759d67f4df6ba1
Submitter: Jenkins
Branch: master

commit 2f2312dfcccda1b421a80f27e6759d67f4df6ba1
Author: Abishek Subramanian <email address hidden>
Date: Tue Jul 15 11:50:07 2014 -0400

    Run router dashboard unit tests by default

    Currently the "router" dashboard does not have its unit tests
    run by default. This was beacuse the dashboard needed to be
    turned on for these tests to be run and turning on this dashboard
    was not mandatory.

    However, now that the dashboards are pluggable, turning on the
    router dashboard tests, and more specifically the Cisco N1K profile
    tests is doable and necessary. This fix aims to remove the checks
    put in place to run the tests only when the dashboard is available
    and instead now run all the tests mandatorily

    Closes-bug: #1229819

    Change-Id: I3c77a71db08ac611e5bdf9274af5a558bfda3327

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/127280

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/127280
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b14a2ec57b6da450f597c6432f136cabafb20526
Submitter: Jenkins
Branch: stable/icehouse

commit b14a2ec57b6da450f597c6432f136cabafb20526
Author: Abishek Subramanian <email address hidden>
Date: Tue Jul 15 11:50:07 2014 -0400

    Run router dashboard unit tests by default

    Currently the "router" dashboard does not have its unit tests
    run by default. This was beacuse the dashboard needed to be
    turned on for these tests to be run and turning on this dashboard
    was not mandatory.

    However, now that the dashboards are pluggable, turning on the
    router dashboard tests, and more specifically the Cisco N1K profile
    tests is doable and necessary. This fix aims to remove the checks
    put in place to run the tests only when the dashboard is available
    and instead now run all the tests mandatorily

    This fix was merged in J-2. Backporting to stable/icehouse
    so that the 'router' dashboard and tests using profile
    are run in Icehouse as well.
    -----

    cherry picked from commit 2f2312dfcccda1b421a80f27e6759d67f4df6ba1

    Conflicts:

     openstack_dashboard/dashboards/project/instances/tests.py

        def test_launch_instance_post_with_profile(self):
            self.test_launch_instance_post(test_with_profile=True)

    Note - Fixed 2 string messages in create_instance.py so as to
    not affect translation and retain previous messages.
    Additionally, fixed minor pep8 errors in instances/test.py
    and networks/tests.py

    Closes-bug: #1229819
    Change-Id: I3c77a71db08ac611e5bdf9274af5a558bfda3327