i18n: network_topology popups are not marked as translatable

Bug #1226159 reported by Łukasz Jernaś
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Juan Manuel Ollé

Bug Description

Most of the strings in openstack_dashboard/dashboards/project/network_topology/templates/network_topology/* aren't marked with trans, so they end up untranslated on the ui.

Most notable examples are:
_svg_element.html
_balloon_container.html
_balloon_device.html
_baloon_port.html

Akihiro Motoki (amotoki)
tags: added: i18n
Changed in horizon:
status: New → Triaged
importance: Undecided → Low
Changed in horizon:
status: Triaged → Confirmed
milestone: none → havana-rc1
Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

At this point even if the missing strings were marked as translatable it would be too late to get them translated. Bumping to I.

Changed in horizon:
milestone: havana-rc1 → icehouse-1
Revision history for this message
David Lyle (david-lyle) wrote :

I will fix _svg_element.html for rc1. The others are client side templates that share a problem with the other existing client side templates that if you don't pass in the translated string to the template, we don't have a general mechanism to get the translated string on the client side.

Revision history for this message
David Lyle (david-lyle) wrote :

Added a blueprint to address the rest, which is a wider problem in most of the client side templates.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49055

Changed in horizon:
assignee: nobody → David Lyle (david-lyle)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/49055
Committed: http://github.com/openstack/horizon/commit/55fa47a315cf0529cd035e0a4989ef736ace6002
Submitter: Jenkins
Branch: master

commit 55fa47a315cf0529cd035e0a4989ef736ace6002
Author: David Lyle <email address hidden>
Date: Mon Sep 30 14:26:13 2013 -0600

    Translating entity types in network topology

    Change-Id: I8e52a15fe606562b7336fefd8c96a38a560a759a
    Partial-bug: #1226159

Akihiro Motoki (amotoki)
tags: added: topology-view
Revision history for this message
Julie Pichon (jpichon) wrote :
tags: added: havana-backport-potential
David Lyle (david-lyle)
Changed in horizon:
assignee: David Lyle (david-lyle) → nobody
David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-1 → icehouse-2
Tom Fifield (fifieldt)
Changed in horizon:
status: In Progress → Confirmed
David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-2 → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/68384

Changed in horizon:
assignee: nobody → Juan Manuel Ollé (juan-m-olle)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/68906

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/68384
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=abff5a7a10ad2b44a57e743271d505b7dfaaa2f8
Submitter: Jenkins
Branch: master

commit abff5a7a10ad2b44a57e743271d505b7dfaaa2f8
Author: Juan Manuel Olle <email address hidden>
Date: Wed Jan 22 10:46:51 2014 -0300

    Translating entity types in network topology

    Change-Id: I4f4e2898f18e994e7fdd29fdb1a478d461313e83
    Partial-bug: #1226159

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/68906
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cd71926d6e8d988df17d978cd15eb4b2ee4de0b2
Submitter: Jenkins
Branch: master

commit cd71926d6e8d988df17d978cd15eb4b2ee4de0b2
Author: Juan Manuel Olle <email address hidden>
Date: Fri Jan 24 10:00:50 2014 -0300

    Translating entity types in client side templates

    This patch changes the remaining labels not localized in
    the client side templates.

    Change-Id: If01b9241ad5f81bbf810ad31bae9b24a2016ee3f
    Closes-bug: #1226159

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.