I18n: Untranslated message is showed in the action confirm dialog

[Ying Chun Guo]

In a table, when I select an action, there is an action confirm dialog promoted. The messages showed in the confirm dialog are untranslated.

For example, in the instance list, select "Terminate Instance", the dialog will be promoted with untranslated messages. The action name is showed as translated. Yet other messages like "Confirm <action name>" "You have selected "test1". Please confirm your selection. This action cannot be undone. " and the button "Cancel" are not translated, still in English.

[Julie Pichon (jpichon)]

Hi Daisy,

This message comes from the djangojs.po file, which until recently wasn't being translated. Could you try to:

1. Update the translation for these messages in horizon/locale/<your_locale>/LC_MESSAGES/djangojs.po
2. Compile the message file (./run_tests.sh --compilemessages)
3. Restart Apache (sudo service apache2 restart or sudo service httpd restart)

and indicate whether the problem is still happening?

It seems the message is broken up in 3 parts which may be something we need to fix to make the string easier to translate.

[Ying Chun Guo (daisy-ycguo)]

Hi, Julie

I updated djangojs.po. The message "You have selected "test1". Please confirm your selection. This action cannot be undone. " is translated. Yet the button "Cancel" is still in English.

Please check.

Daisy

[Julie Pichon (jpichon)]

Right. "Cancel" in modal.js needs to be in a gettext().

https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.modals.js#L33

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/46270

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/46270
Committed: http://github.com/openstack/horizon/commit/89c648e3b42f69aa757120461b0bc2b9767a5c3b
Submitter: Jenkins
Branch: master

commit 89c648e3b42f69aa757120461b0bc2b9767a5c3b
Author: Julie Pichon <email address hidden>
Date: Wed Sep 11 20:05:32 2013 +0100

    Internationalise a couple of forgotten strings

    Change-Id: Ia17cbcd7d5127ca83a925ce9f31bf095a23062e8
    Partial-Bug: #1224338
    Closes-Bug: #1224289