I18n: Untranslated message is showed in the action confirm dialog

Bug #1224289 reported by Ying Chun Guo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Julie Pichon

Bug Description

In a table, when I select an action, there is an action confirm dialog promoted. The messages showed in the confirm dialog are untranslated.

For example, in the instance list, select "Terminate Instance", the dialog will be promoted with untranslated messages. The action name is showed as translated. Yet other messages like "Confirm <action name>" "You have selected "test1". Please confirm your selection. This action cannot be undone. " and the button "Cancel" are not translated, still in English.

Tags: i18n
Revision history for this message
Julie Pichon (jpichon) wrote :

Hi Daisy,

This message comes from the djangojs.po file, which until recently wasn't being translated. Could you try to:

1. Update the translation for these messages in horizon/locale/<your_locale>/LC_MESSAGES/djangojs.po
2. Compile the message file (./run_tests.sh --compilemessages)
3. Restart Apache (sudo service apache2 restart or sudo service httpd restart)

and indicate whether the problem is still happening?

It seems the message is broken up in 3 parts which may be something we need to fix to make the string easier to translate.

Changed in horizon:
status: New → Incomplete
Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :

Hi, Julie

I updated djangojs.po. The message "You have selected "test1". Please confirm your selection. This action cannot be undone. " is translated. Yet the button "Cancel" is still in English.

Please check.

Daisy

Revision history for this message
Julie Pichon (jpichon) wrote :
Changed in horizon:
status: Incomplete → Opinion
status: Opinion → Triaged
Julie Pichon (jpichon)
Changed in horizon:
importance: Undecided → Low
assignee: nobody → Julie Pichon (jpichon)
milestone: none → havana-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46270

Changed in horizon:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/46270
Committed: http://github.com/openstack/horizon/commit/89c648e3b42f69aa757120461b0bc2b9767a5c3b
Submitter: Jenkins
Branch: master

commit 89c648e3b42f69aa757120461b0bc2b9767a5c3b
Author: Julie Pichon <email address hidden>
Date: Wed Sep 11 20:05:32 2013 +0100

    Internationalise a couple of forgotten strings

    Change-Id: Ia17cbcd7d5127ca83a925ce9f31bf095a23062e8
    Partial-Bug: #1224338
    Closes-Bug: #1224289

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.