Horizon displays two contradictory Messages when a user deletes a non empty Swift container

[Nir Magnezi]

Description of problem:
==================
Horizon displays two contradictory Messages when a user deletes a non empty swift container.
In addition to that, The Swift container is not really deleted.

Version-Release number of selected component (if applicable):
=================================================
python-django-horizon-2013.1.3-1

How reproducible:
==============
Always

Steps to Reproduce:
================
1. Login and Browse to: http://<HOST_FQDN>/dashboard/project/containers/
2. Create a Swift container via Horizon.
3. Upload an object to that container.
4. Click Delete Container.

Actual results:
===========
Both messages:
Warning: The container cannot be deleted since it's not empty.
Success: Deleted Container: test_container

Expected results:
==============
I'm not sure what is the expected result here, Meaning whether the container should be deleted or not.
According to: https://bugs.launchpad.net/horizon/+bug/1096084/comments/6 , the container content should be deleted recursively.

[Nir Magnezi (nmagnezi)]

screen shot

[Julie Pichon (jpichon)]

According to the patch in the linked bug report, the correct behaviour should be to display a warning message and not delete the container. We definitely should not have both a warning message and a success message though. I can reproduce this in devstack.

[Kieran Spear (kspear)]

+1. I noticed the same thing yesterday. IIRC this got backported too.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/51970

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/51970
Committed: http://github.com/openstack/horizon/commit/52957cc7d9934839c80f674886769f13c2e66670
Submitter: Jenkins
Branch: master

commit 52957cc7d9934839c80f674886769f13c2e66670
Author: Lin Hua Cheng <email address hidden>
Date: Tue Oct 15 15:51:54 2013 -0700

    Show success msg when container deletion succeeds

    When user tries to delete non-empty container, the success messsage
    should not be displayed.

    Change-Id: I02ba1e4bad8dbe2b52f06f2a8e079b5812cd5544
    Closes-bug: 1214842

[Ashish Chandra (ashish-chandra)]

IMHO, this should also be backported to stable/Havana, coz people using Havana still be getting this issue.