Code cleanup for Heat Resource Topology

Bug #1201980 reported by Lin Hua Cheng
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Tim Schnell

Bug Description

The code for ajax query should be moved from stacks/api.py (https://review.openstack.org/#/c/36351/7/openstack_dashboard/dashboards/project/stacks/api.py) into the stacks/views.py.

The api class should only code for abstracting the backend call and is not intended for returning ajax response. Please move the code to views.py

Changed in horizon:
importance: Undecided → Wishlist
tags: removed: wishlist
Revision history for this message
Tim Schnell (tim-schnell) wrote :

Thanks Lin Hua Cheng, I'll move the ajax function

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/37694

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/37694
Committed: http://github.com/openstack/horizon/commit/2c1e47d5c5410de9f9a02dffddc62f4a00e2b85b
Submitter: Jenkins
Branch: master

commit 2c1e47d5c5410de9f9a02dffddc62f4a00e2b85b
Author: Tim Schnell <email address hidden>
Date: Thu Jul 18 10:02:07 2013 -0500

    Fixing the AJAX function location

    This bug addresses the incorrect location of the AJAX function call in api.py and moves it to the correct location in views.py
    It also standardizes the AJAX JSON function to use a generic Django class instead of a function.

    Change-Id: I445ca58d1e05187c9d05fdb6814039c69543324c
    Fixes: bug #1201980

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.