_get_instances() in Admin volume panel is not scoped properly

Bug #1193002 reported by David Lyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
David Lyle

Bug Description

the _get_instances() method only calls server_list for the currently scoped project. Calling this method as is from the Admin dashboard means correlating instances and volumes will fail in most cases, because search_opts does not contain all_tenants=True

David Lyle (david-lyle)
Changed in horizon:
assignee: nobody → David Lyle (david-lyle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/33893

Changed in horizon:
status: New → In Progress
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/33893
Committed: http://github.com/openstack/horizon/commit/73e62610cf68206929af331dfbfc99e5a240e544
Submitter: Jenkins
Branch: master

commit 73e62610cf68206929af331dfbfc99e5a240e544
Author: David Lyle <email address hidden>
Date: Thu Jun 20 16:08:03 2013 -0600

    Fixing scoping of instances in admin volume view

    Existing code was only getting instances scoped to the user's
    current token. When calling from the admin volumes view, this
    needs to get all instances to correlate volume attachments.

    Changed get_volumes to pass all_tenants=True to be consistent,
    cinder ignores the value anyway and only looks for the all_tenants
    key.

    Fixes: bug #1193002

    Change-Id: I5ed2a63997126911d6657619b062acd2947d06e1

Changed in horizon:
status: In Progress → Fix Committed
David Lyle (david-lyle)
Changed in horizon:
milestone: none → havana-2
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.