Duplicate Networks in Networking Tab

[Derek Morton]

After importing an SSH key through the "Launch Instance" interface the available networks listed on the "Networking" tab are duplicated, with only one set actually functioning (clicking on the non-functional ones just causes them to move around in the list if you have more than one network).

This is occurring in the Ubuntu Grizzly packages on 13.04 and also in Devstack when pulling from the master branch.

Steps to reproduce:

1) Launch instance creator UI from within Horizon
2) Import a keypair on the "Access & Security" tab
3) Switch to "Networking" tab and see duplicate networks under available networks

root@controller:~# dpkg -s openstack-dashboard
Package: openstack-dashboard
Status: install ok installed
Priority: extra
Section: net
Installed-Size: 5159
Maintainer: Chuck Short <email address hidden>
Architecture: all
Source: horizon
Version: 1:2013.1-0ubuntu2

root@controller:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu Raring Ringtail (development branch)
Release: 13.04
Codename: raring

[Julie Pichon (jpichon)]

Strange. I can reproduce on latest devstack.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/28032

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/28032
Committed: http://github.com/openstack/horizon/commit/0512a12d07900430e8b399dcc27cade77d390491
Submitter: Jenkins
Branch: master

commit 0512a12d07900430e8b399dcc27cade77d390491
Author: Tomas Sedovic <email address hidden>
Date: Thu May 2 11:56:59 2013 +0200

    Don't duplicate networks list on keypair import

    In the Launch Instance modal, if the user clicks on the button to import
    a keypair, the networks listed in the Networking tab get duplicated.

    The import keypair button calls `workflow_init` which in turn calls
    `generate_networklist_html` which appended the networks to the list, not
    clearing it beforehand.

    This makes sure both Selected Networks and Available Networks lists are
    emptied before the networks are added.

    Fixes bug 1170193

    Change-Id: Icb750caa08673068c509af6c8df1ad57a2a30d93
    Signed-off-by: Tomas Sedovic <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/39489

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39489
Committed: http://github.com/openstack/horizon/commit/af83ed8bd487f8cc921ef6372d0a1c3bdaab63e3
Submitter: Jenkins
Branch: stable/grizzly

commit af83ed8bd487f8cc921ef6372d0a1c3bdaab63e3
Author: Tomas Sedovic <email address hidden>
Date: Thu May 2 11:56:59 2013 +0200

    Don't duplicate networks list on keypair import

    In the Launch Instance modal, if the user clicks on the button to import
    a keypair, the networks listed in the Networking tab get duplicated.

    The import keypair button calls `workflow_init` which in turn calls
    `generate_networklist_html` which appended the networks to the list, not
    clearing it beforehand.

    This makes sure both Selected Networks and Available Networks lists are
    emptied before the networks are added.

    Fixes bug 1170193

    Change-Id: Icb750caa08673068c509af6c8df1ad57a2a30d93
    Signed-off-by: Tomas Sedovic <email address hidden>
    (cherry picked from commit 0512a12d07900430e8b399dcc27cade77d390491)