Modal upload forms with FileField revert to un-modal on validation error

[Steve Baker]

Any modal form which contains a FileField will revert to being non-modal when the form is re-displayed for a validation error.

Currently this would affect the following forms:
Images and Snapshots -> Create Image
Containers -> Upload Object

This is happening because the ajax POST technique doesn't work for enctype="multipart/form-data" forms.

A short term workaround could be to start these forms as non-modal, even though this isn't consistent with the look of other forms, is less disconcerting than triggering this bug.

A long term fix would be to implement ajax uploading (google 'django ajax upload'), which may be worthy of a blueprint.

[Gabriel Hurley (gabriel-hurley)]

Agreed on the problem. The behavior was semi-intentional given the problem with multipart uploads you pointed out. Having a bug to remember this and to address it in the future is good, though.

[Ladislav Smola (lsmola)]

The blueprints that should implement system for uploads already exists here:

https://blueprints.launchpad.net/horizon/+spec/file-upload-redux
https://blueprints.launchpad.net/horizon/+spec/multi-file-upload
https://blueprints.launchpad.net/horizon/+spec/swift-direct-upload

So this should be also connected to File Upload solution from the blueprints

[Prathyusha Vanka (prathyusha-vanka)]

Presently there is a comment especially for "enctype"
" AJAX upload for files is not currently supported ".
Can we proceed to solve this bug?

[Cindy Lu (clu-m)]

Another example of problem is seen on 'Launch Stack' modal. After you select a template and press "Next", it reverts to un-modal.

[Timur Sufiev (tsufiev-x)]

Prathyusha, do you mind if I take this bug?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/107769

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/108402

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timur Sufiev (<email address hidden>) on branch: master
Review: https://review.openstack.org/108402
Reason: Wrong change id

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/107769
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b88aaa16d3e718cfe5f0509c5a47c51887884f35
Submitter: Jenkins
Branch: master

commit b88aaa16d3e718cfe5f0509c5a47c51887884f35
Author: Timur Sufiev <email address hidden>
Date: Mon Jul 21 19:13:15 2014 +0400

    Allow form to stay modal after uploading file

    Use HTML5 FormData browser API together with FileList API to make
    possible AJAX file uploads (see http://tinyurl.com/kmznw2n on FormData
    examples). Feature detection is the same as in jQuery Form Plugin (see
    http://tinyurl.com/n6v5dsx). Browsers without FormData support (most
    importantly, IE<10) do not support setting custom AJAX request
    headers, so form with File Upload field will lose modality in them
    anyway.

    Change-Id: Id3b91a49a71c6de314c6a7cbee5357fe13679490
    Closes-Bug: #1158501