Some Lbaas fields require ints but declared as CharFields

Bug #1153525 reported by Ilya Shakhat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Tatiana Ovchinnikova

Bug Description

Many fields in Load Balancer screens accept integer values, but implemented as CharFields. The implementation needs to be changed to IntegerField in order to avoid entering letters and validating the range of correct values.

Affected fields are:
 * Vip / protocol port
 * Vip / connection limit
 * Member / protocol port
 * Member / weight
 * Monitor / delay
 * Monitor / timeout
 * Monitor / max_retries

Tags: lbaas quantum
Ilya Shakhat (shakhat)
Changed in horizon:
assignee: nobody → Ilya Shakhat (shakhat)
summary: - Lbaas delay, timeout and max retries fields must be IntegerField, not
- CharField
+ Some Lbaas fields require ints but declared as CharFields
Akihiro Motoki (amotoki)
tags: added: lbaas quantum
Akihiro Motoki (amotoki)
Changed in horizon:
status: New → Confirmed
Changed in horizon:
importance: Undecided → Low
milestone: none → havana-1
Changed in horizon:
assignee: Ilya Shakhat (shakhat) → Tatiana Mazur (tmazur)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24981

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/24981
Committed: http://github.com/openstack/horizon/commit/0783e62e05c116955373b285b9396e96c1b9f2b9
Submitter: Jenkins
Branch: master

commit 0783e62e05c116955373b285b9396e96c1b9f2b9
Author: Tatiana Mazur <email address hidden>
Date: Thu Mar 28 16:03:01 2013 +0400

    CharFields replaced by IntegerFields in LBaaS forms.

    The following fields were changed:
    * Vip / protocol port
    * Vip / connection limit
    * Member / protocol port
    * Member / weight
    * Monitor / delay
    * Monitor / timeout
    * Monitor / max_retries

    Added range validations:
    * Vip / protocol port -- in range [1..65535]
    * Vip / connection limit -- more or equal that 0 or -1 if the limit is not set
    * Member / protocol port -- in range [1..65535]
    * Member / weight -- in range [0..256]
    * Monitor / delay -- more or equal that 1
    * Monitor / timeout -- more or equal that 1
    * Monitor / max_retries -- in range [1..10]

    Fixes bug 1153525

    Change-Id: I7bf9fe24060dc85076d9be2e6592a51a33fefeae

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.