Object Upload is validated after object upload

[Stuart Stent]

on the "Upload Object To Container" popup, if you select a file and do NOT enter an object name, you dont get a failure message until after the file has uploaded.

There should be some client side valiadtion of the Object Name field on pressing the "Upload Object" button

[Cristian A Sanchez (cristian-a-sanchez)]

This bug have been there for a long time. Fab: is it ok if I assign this to me?

[David Lapsley (dlapsley)]

I've run into this one too. A side-effect is that the uploaded file stays in the tmp-upload directory and is "leaked" (i.e. never cleaned up). Christian, let me know if you need help on this one...

[Cristian A Sanchez (cristian-a-sanchez)]

Hi,
I¹m almost done with this fix. It¹ll be great if you could review the code
after I commit it.
Thank you

Cristian

On 20/11/13 12:33, "David Lapsley" <email address hidden> wrote:

>I've run into this one too. A side-effect is that the uploaded file
>stays in the tmp-upload directory and is "leaked" (i.e. never cleaned
>up). Christian, let me know if you need help on this one...
>
>--
>You received this bug notification because you are a bug assignee.
>https://bugs.launchpad.net/bugs/1125232
>
>Title:
> Object Upload is validated after object upload
>
>Status in OpenStack Dashboard (Horizon):
> Confirmed
>
>Bug description:
> on the "Upload Object To Container" popup, if you select a file and do
> NOT enter an object name, you dont get a failure message until after
> the file has uploaded.
>
> There should be some client side valiadtion of the Object Name field
> on pressing the "Upload Object" button
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/horizon/+bug/1125232/+subscriptions

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57499

[David Lapsley (dlapsley)]

Hi Christian: looking at it now.

Cheers, David.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/60320

[Cristian A Sanchez (cristian-a-sanchez)]

Hi Maxime, I was working on this. Would have been nice to know that you were to submit a patch.

[Maxime Vidori (maxime-vidori)]

Hey! sorry for that, I did not see you yesterday, and nothing today so I have some time to loose... I do not mind if you want to take this patch on your own.

Sorry again, ping me on IRC if you want to get this, I think it will have some things to improve before the merge.

[Cristian A Sanchez (cristian-a-sanchez)]

That is fine. I can review your change and then help you on those things to improve

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/60320
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b37b9d5fc43bb6757b8c1a28d521214944ac594e
Submitter: Jenkins
Branch: master

commit b37b9d5fc43bb6757b8c1a28d521214944ac594e
Author: Maxime Vidori <email address hidden>
Date: Thu Dec 5 18:04:57 2013 +0100

    Object Upload validated on client side

        Perform a js validation of the Object Upload name. If the name is
    not entered, the submit button will appears disabled.

    Fixes bug #1125232
    Change-Id: Id33f3999e9267f5fc58eb55406fc5b763597839b
    Co-Authored-By: Cristian A Sanchez <email address hidden>