Move dashboard workflow templates into common

Bug #1115692 reported by Kieran Spear
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Wishlist
Unassigned

Bug Description

All the workflow templates are identical except for the title. We can move this template into common and replace the title with {{ workflow.name }}.

kspear@kspear:~/openstack/horizon/openstack_dashboard/dashboards$ grep -r _workflow.html * | cut -d: -f1
admin/projects/templates/projects/update.html
admin/projects/templates/projects/create.html
admin/networks/templates/networks/subnets/update.html
admin/networks/templates/networks/subnets/create.html
project/access_and_security/templates/access_and_security/floating_ips/associate.html
project/instances/templates/instances/launch.html
project/networks/templates/networks/subnets/update.html
project/networks/templates/networks/subnets/create.html
project/networks/templates/networks/create.html

kspear@kspear:~/openstack/horizon/openstack_dashboard/dashboards$ grep -r _workflow.html * | cut -d: -f1 | xargs cat | sort | uniq
{% block main %}
{% block page_header %}
{% block title %}Create Project{% endblock %}
{% block title %}{% trans "Associate Floating IP" %}{% endblock %}
{% block title %}{% trans "Create Network" %}{% endblock %}
{% block title %}{% trans "Create Subnet" %}{% endblock %}
{% block title %}{% trans "Edit Project" %}{% endblock %}
{% block title %}{% trans "Launch Instance" %}{% endblock %}
{% block title %}{% trans "Update Subnet" %}{% endblock %}
{% endblock %}
{% endblock page_header %}
{% extends 'base.html' %}
  {% include "horizon/common/_page_header.html" with title=_("Associate Floating IP") %}
  {% include "horizon/common/_page_header.html" with title=_("Create Network") %}
  {% include "horizon/common/_page_header.html" with title=_("Create Project") %}
  {% include "horizon/common/_page_header.html" with title=_("Create Subnet") %}
  {% include "horizon/common/_page_header.html" with title=_("Edit Project") %}
  {% include "horizon/common/_page_header.html" with title=_("Launch Instance") %}
  {% include "horizon/common/_page_header.html" with title=_("Update Subnet") %}
  {% include 'horizon/common/_workflow.html' %}
  {% include "horizon/common/_workflow.html" %}
{% load i18n %}

Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

This would be fantastic!

Changed in horizon:
importance: Undecided → Wishlist
milestone: none → grizzly-3
status: New → Confirmed
Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
Thierry Carrez (ttx)
Changed in horizon:
milestone: grizzly-3 → grizzly-rc1
Changed in horizon:
milestone: grizzly-rc1 → havana-1
Changed in horizon:
assignee: Gabriel Hurley (gabriel-hurley) → nobody
Revision history for this message
Tihomir Trifonov (ttrifonov) wrote :
Changed in horizon:
milestone: havana-1 → havana-2
Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
Changed in horizon:
milestone: havana-2 → havana-3
Changed in horizon:
milestone: havana-3 → none
Revision history for this message
Akihiro Motoki (amotoki) wrote :

The workflow template has been improved and the reported issue has been addressed, so Invalid.

Changed in horizon:
assignee: Gabriel Hurley (gabriel-hurley) → nobody
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.