Edit Flavor Window Displays Details of Deleted Flavors

[Sean Carlisle]

A user deletes all existing flavors and creates new flavors. When they click the "Edit Flavors" button, the window displays the details of the deleted flavor of the same flavor ID. This window appears to disregard the deleted flag in the table nova.instance_types and pulls the first row that matches the flavor ID.

Steps to reproduce:

1.) Delete all existing flavors.
2.) Create a new flavor through the dashboard.
3.) Once the flavor has been created, click the "Edit Flavor" button.

Thank you,

Sean Carlisle

[Tony NIU (niuwl586-v)]

It is a bug of nova-api. When dashboard call api "v2/{tenant_id}/flavors/{flavor_id}", nova-api return the deleted flavor infomation.

[Kieran Spear (kspear)]

@Sean: Are you using the Folsom release? I can repro on Folsom Horizon but not on master.

I'm pretty sure this was fixed when Horizon switched to using UUIDs for flavor ids in:

https://review.openstack.org/#/c/14787/

Using a string for flavor id seems to be supported by Nova stable/folsom, so probably a good candidate for backporting.

[Sean Carlisle (sean-carlisle)]

@Kieran: Yes this is with the Folsom release. However, I think Tony is correct about the bug existing in the Nova API. I was just able to recreate the issue by deleting a flavor, creating a new one with the same flavor ID using Nova CLI, then used curl to retrieve the description of that flavor ID.

[Kieran Spear (kspear)]

@Sean: Yeah, looks like it. I think there are some cases that need to get a deleted flavor (e.g., if it's still referenced by an existing instance). But there's no way to tell the API to exclude it when retrieving a flavor by id, and it would seem there's also no way to tell whether an instance is tied to the new or old flavor if IDs are the same.

I'll ask openstack-dev.

[Masayuki Igawa (igawa)]

I'm facing the same issue in Folsom. So I've added 'folsom-backport-potential' tag to bug 1057799 .

By the way, I noticed the codes of generating uuid was removed by bug 1076761 in master.
Should we add 'folsom-backportable' tag to bug 1076761 ?

[Gabriel Hurley (gabriel-hurley)]

Sounds like this is only present in Folsom at this point. I've retargeted the bug.

[Ryan Richard (ryan-richard)]

I guess the main problem is that flavors that are being used are allowed to be deleted and the allowing the creation of new flavors with the same IF as another.

Perhaps the original idea was to allow the deletion of a flavor so no instances could use that flavor but running instances built from that flavor still need to have that relationship in the database.