pep8 check ignores identation errors
Bug #1085346 reported by
Lin Hua Cheng
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Won't Fix
|
Wishlist
|
Unassigned |
Bug Description
The indentation check for pep8 have been changed to be relax.
In the sample code:
ram = tables.
verbose_
attrs=
Second and third line only has one space indented, and pep8 check passes. Should this be made stricter?
Changed in horizon: | |
milestone: | grizzly-2 → grizzly-3 |
Changed in horizon: | |
milestone: | grizzly-3 → none |
Changed in horizon: | |
assignee: | nobody → Simon Luo (simon-t) |
description: | updated |
Changed in horizon: | |
assignee: | Simon Luo (simon-t) → Akihiro Motoki (amotoki) |
Changed in horizon: | |
assignee: | Akihiro Motoki (amotoki) → Simon Luo (simon-t) |
Changed in horizon: | |
assignee: | Simon Luo (simon-t) → Akihiro Motoki (amotoki) |
Changed in horizon: | |
assignee: | Akihiro Motoki (amotoki) → Simon Luo (simon-t) |
Changed in horizon: | |
status: | In Progress → Confirmed |
assignee: | Simon Luo (simon-t) → nobody |
To post a comment you must log in.
That's not ideal, certainly. I believe that change came from pep8.py v1.2 or 1.3 including some really inappropriately strict whitespace checking so we turned it off. If we can set it to a happy medium that fits the current coding style (aside from that particular example) we can turn it back on, otherwise we should fix any cases of bad indents and just catch them in reviews.