pep8 check ignores identation errors

[Lin Hua Cheng]

The indentation check for pep8 have been changed to be relax.

In the sample code:

ram = tables.Column(get_size,
 verbose_name=_('RAM'),
 attrs={'data-type': 'size'})

Second and third line only has one space indented, and pep8 check passes. Should this be made stricter?

[Gabriel Hurley (gabriel-hurley)]

That's not ideal, certainly. I believe that change came from pep8.py v1.2 or 1.3 including some really inappropriately strict whitespace checking so we turned it off. If we can set it to a happy medium that fits the current coding style (aside from that particular example) we can turn it back on, otherwise we should fix any cases of bad indents and just catch them in reviews.

[Kun Huang (academicgareth)]

The E121 (65 lines), E126 (108), E127(350), E128(282) are relative with this bug.
I think we could submit four commits for each E12X by using "Partial-Bug: #1085346"

[Simon Luo (simon-t)]

Thansk for your comments, I agree with you. so i must commit this bugfix with four patch like this:
bug/1085346#1/4
bug/1085346#2/4
bug/1085346#3/4
bug/1085346#4/4

right?
Looking forward to your reply.

Kind Regards
Simon Luo

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/45182

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/45192

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/45182
Committed: http://github.com/openstack/horizon/commit/ec727ac39426c2a6be70a7c9cf75c00e4ae0c91c
Submitter: Jenkins
Branch: master

commit ec727ac39426c2a6be70a7c9cf75c00e4ae0c91c
Author: simon <email address hidden>
Date: Thu Sep 5 14:38:58 2013 +0800

    PEP8 E121 has been resolved

    Change-Id: I6ad2704100447c5a3be12c2ebeec824726e3bd0b
    Partial-Bug: #1085346

[Simon Luo (simon-t)]

Waiting for the second bugfix will have been merged, then I can commit the third bugfix.

Every commit for this bug, always changed the most files, and conflicts also happen when you submit a new commit.

thanks

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/45192
Committed: http://github.com/openstack/horizon/commit/afaa72185cf2e1a41ef685778111d8f51515e050
Submitter: Jenkins
Branch: master

commit afaa72185cf2e1a41ef685778111d8f51515e050
Author: simon <email address hidden>
Date: Thu Sep 5 15:49:35 2013 +0800

    PEP8 E126 has been resolved

    Change-Id: Ic5d3b96b6061b7a34e7620d8d09418bd6976fbb1
    Partial-Bug: #1085346

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/48826

[Lin Hua Cheng (lin-hua-cheng)]

This is alaready resolved by https://review.openstack.org/#/c/125137/