OpenStack Dashboard (Horizon)

Inconsistency in 'Quota exceeded' error handling in forms

Reported by Tihomir Trifonov on 2012-10-24
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Low
Imre Farkas

Bug Description

All different forms have completely different behavior when the quota is full.

1. Instances: you can submit a 'Create instance' form, but it raises a
"Error: There was an error submitting the form. Please try again." after the form is closed.

2. Volumes: can submit the form, and shows a form error.

3. Floating IPs: the 'Allocate IP' button is disabled. If however I submit the form - it shows
"Error: There was an error submitting the form. Please try again." after the form is closed.

Gabriel Hurley (gabriel-hurley) wrote :

Agreed. If you look in the volume form it actually does some checking in the validation code. The others are simply allowing it to go to the API and returning a generic API error.

Changed in horizon:
importance: Undecided → Low
milestone: none → grizzly-1
status: New → Confirmed
Changed in horizon:
milestone: grizzly-1 → grizzly-2
Changed in horizon:
milestone: grizzly-2 → grizzly-3
Changed in horizon:
milestone: grizzly-3 → none
Imre Farkas (ifarkas) on 2013-05-21
Changed in horizon:
assignee: nobody → Imre Farkas (ifarkas)

Fix proposed to branch: master
Review: https://review.openstack.org/32113

Changed in horizon:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/32113
Committed: http://github.com/openstack/horizon/commit/32c863e8448020348ea020f6a90898bd82418fcd
Submitter: Jenkins
Branch: master

commit 32c863e8448020348ea020f6a90898bd82418fcd
Author: Imre Farkas <email address hidden>
Date: Thu May 30 14:52:00 2013 +0200

    Improve consistency of quota checking in forms

    Add quota based validations to floating_ips and instance forms. Unify
    the implementation of disabled/enabled button for instance and
    floating_ips table. Add disabled/enalbed button to volumes table.

    Change-Id: I488e86e467369f35244bdcd34ecaaee32e56ba2d
    fixes: bug #1070899

Changed in horizon:
status: In Progress → Fix Committed
David Lyle (david-lyle) on 2013-08-22
Changed in horizon:
milestone: none → havana-3
Thierry Carrez (ttx) on 2013-09-05
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in horizon:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers