OpenStack Dashboard (Horizon)

Batch action messages should filter None from join()

Bug #1030641 reported by Gabriel Hurley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Tihomir Trifonov
OpenStack Dashboard (Horizon) 2012.2 "folsom"

Bug Description

Under rare circumstances (usually error conditions) it's possible for None to be returned instead of a Resource's name. As such we should filter None out of action_success in the handle() method of BatchAction.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/10901

Changed in horizon:
assignee: Nebula (nebula) → Tihomir Trifonov (ttrifonov)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/10901
Committed: http://github.com/openstack/horizon/commit/68e612d37fe2e648f17469f8e92677081c1a2982
Submitter: Jenkins
Branch: master

commit 68e612d37fe2e648f17469f8e92677081c1a2982
Author: Tihomir Trifonov <email address hidden>
Date: Mon Aug 6 19:28:16 2012 +0300

    Added a check for None value in get_object_display

    When get_object_display returns None,
    the concatenation of the list of display values fails.

    Fixes bug 1030641

    PATCH SET 2: Added function for joining of
    lazy(proxy) strings(similar to string_concat)

    Change-Id: I76398e85f93bc508aaae056aca77c8103998c7b6

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.