broken instance linkage under project overview page

[Edward]

Under project overview page, the instances are listed as summary. But the linkage of instance is broken. The instance id included in the URL is not an uuid. But the same instance link is correct under project "Instance & Volumes" page.

Here's an example of broken URL:
http://192.168.156.180/nova/instances_and_volumes/instances/140534011350288/detail

The correct link is:
http://192.168.156.180/nova/instances_and_volumes/instances/54aa4c71-d2c6-44c5-a46f-fba0d969a6b7/detail

[Vincent Hou (houshengbo)]

Under Tab instances & volumes, we can click the instance name and go to the detail page of this instance, if there are instances available.
When switching to the Tab Overview, clicking the instance name will lead to this error.

[Edward (zhang-hare)]

from code analysis, the id included in the URL is not an actual instance id, but a build-in object id. The summary usage information in overview page for each tenant seems incomplete in current implementation. It is using tenant usage data instead of all listed instances usage information.

View:

horizon/horizon/dashboard/nova/overview/view.py
...
class ProjectOverview(usage.UsageView):
    table_class = usage.TenantUsageTable
    usage_class = usage.TenantUsage
    template_name = 'nova/overview/usage.html'

    def get_data(self):
        super(ProjectOverview, self).get_data()
        return self.usage.get_instances()

Model:

horizon/horizon/usage/tables.py
...
class TenantUsageTable(BaseUsageTable):
    instance = tables.Column('name',
                             verbose_name=_("Instance Name"),
                             link=("horizon:nova:instances_and_volumes:"
                                   "instances:detail"))
    uptime = tables.Column('uptime_at',
                           verbose_name=_("Uptime"),
                           filters=(timesince,))

    def get_object_id(self, datum):
       ''' This is actual an build-in object id, not the instance id. '''
        return id(datum)

    class Meta:
        name = "tenant_usage"
        verbose_name = _("Usage Summary")
        columns = ("instance", "vcpus", "disk", "memory", "uptime")
        table_actions = (CSVSummary,)
        multi_select = False

[Gabriel Hurley (gabriel-hurley)]

Yep. That's just broken. Good catch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/8259

[Lin Hua Cheng (lin-hua-cheng)]

Gabriel,

when the user clicks on the instance link, is it supposed to open the link /syspanel/projects/<tenant_id>/usage ?

Or does it need an entirely new page to open?

[Lin Hua Cheng (lin-hua-cheng)]

Bug has dependency on: https://bugs.launchpad.net/nova/+bug/1003093

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/8837

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/8837
Committed: http://github.com/openstack/horizon/commit/a6703494206ba72c1df46950c4425076e154d730
Submitter: Jenkins
Branch: master

commit a6703494206ba72c1df46950c4425076e154d730
Author: Lin Hua Cheng <email address hidden>
Date: Thu Jun 21 21:55:57 2012 -0700

    Fix Project Overview link to use instance_id

    Fixes Bug #1003299

    Tenant Usage API has been updated to include
    instance_id in the response (bug 1003093). The
    link has been updated to used instance_id.

    Change-Id: I9d5fcf120b1e5966a5e019e5b17dea7806f20650