compile problem with gtk 2.23 with deprecated flags

Reported by Filipe Rosset on 2010-12-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HomeBank
Medium
Maxime Doyen
Fedora
Unknown
Unknown

Bug Description

HomeBank 4.3 doesn't compile on Fedora 15

The link with the error is here: https://bugzilla.redhat.com/attachment.cgi?id=466867

Can you please take a look why its happening?

Filipe Rosset (rosset) wrote :

I had to remove -DGTK_DISABLE_DEPRECATED on the configure files, can you please update the sources and avoid to use DEPRECATED functions?

Can you please try to build the sources against a newer GTK2 version?

Cheers,

--- configure.ac.original 2010-12-31 00:52:27.654282449 -0200
+++ configure.ac 2010-12-31 00:53:18.635259725 -0200
@@ -33,7 +33,7 @@

 # Usual c & gtk cflags
-CFLAGS="${CFLAGS} -Wall -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED"
+CFLAGS="${CFLAGS} -Wall -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED"

 # Check for libofx

--- configure.original 2010-12-31 00:52:18.532928659 -0200
+++ configure 2010-12-31 00:52:55.432359838 -0200
@@ -4537,7 +4537,7 @@

 # Usual c & gtk cflags
-CFLAGS="${CFLAGS} -Wall -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED"
+CFLAGS="${CFLAGS} -Wall -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED"

 # Check for libofx

Maxime Doyen (mdoyen) wrote :

@Filipe: does these 2 questions are for me of for fedora package maintainer ?

Maxime Doyen (mdoyen) on 2011-01-02
Changed in homebank:
assignee: nobody → Maxime DOYEN (mdoyen)
status: New → Incomplete
Filipe Rosset (rosset) wrote :

Hi Maxime,

I'm the new maintainer of HomeBank on Fedora :)

Which version of GTK are you using to build the 4.3 tree?
I'm asking it because on Fedora 15 we have gtk2-2.23, and I'm sure if you build HomeBank against this version in any other OS you can see the same problem.
Maybe, can you update the deprecated functions in 4.4. tree? :)

Cheers,

Maxime Doyen (mdoyen) wrote :

build under ubuntu 10.10, with gtk 2.22
I will see what to do with deprecated function in 2.23 for sure in 4.4.

Changed in homebank:
importance: Undecided → Low
status: Incomplete → Confirmed
milestone: none → 4.4
Filipe Rosset (rosset) wrote :

Hi Maxime,

Thanks for the update, I'll inform you if we've found other bugs.

Cheers,

Maxime Doyen (mdoyen) on 2011-01-07
summary: - HomeBank 4.3 doesn't compile on Fedora 15
+ compile problem with gtk 2.23 with deprecated flags
Maxime Doyen (mdoyen) wrote :

GtkComboBoxEntry is deprecated since version 2.23.

So the correct workaround is to remove the GTK_DISABLE_DEPRECATED flag.

I will do the chnage, but for v4.5, not the 4.4

Changed in homebank:
importance: Low → Medium
milestone: 4.4 → 4.5
Maxime Doyen (mdoyen) wrote :

I have modified the configure.ac to not check for deprecated.
I keep this usage for the dev, not for release.
This will be fixed for the soon coming v4.4

Changed in homebank:
milestone: 4.5 → 4.4
Maxime Doyen (mdoyen) on 2011-01-13
Changed in homebank:
status: Confirmed → Fix Committed
Maxime Doyen (mdoyen) on 2011-01-17
Changed in homebank:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.