wish: import to always shows date tolerance

Bug #1586211 reported by Kinnin Vo-Shay on 2016-05-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HomeBank
Wishlist
Maxime DOYEN

Bug Description

When importing OFX files, the import assistant only shows the "Date Tolerance" field if a duplicate transaction is found as an exact match right away. This means if there are no exact match duplicate transactions, there is no way for me to change the date tolerance to detect duplicate transactions that are not exact matches.

Some additional nice to haves would be:
1) Not needing to click the refresh button when changing the date tolerance (i.e. it auto-refreshes on a change in tolerance).
2) Being able to set a non-zero date tolerance as the default in the preferences.

(let me know if you'd like me to submit a separate bug for these)

Maxime DOYEN (mdoyen) on 2016-10-15
summary: - Import does not show date tolerance
+ wish: import to always shows date tolerance
tags: added: file-import-export
Changed in homebank:
importance: Undecided → Wishlist
Kinnin Vo-Shay (vo-shay) wrote :

I tried my hand at updating the code to address this, and I think I've it working. Attached is the file with my code changes to the 5.1.3 trunk.

The code changes accomplish the following:
1) Make the date tolerance toggle and related labels appear all the time
2) Remove the need for the Refresh button by automatically refreshing the list when the tolerance is changed
3) Make the duplicate transaction details list dynamically appear when duplicates are detected (hidden otherwise)
4) Consistently take the date tolerance value into account when filtering

I hope I've made the UI changes correctly, but this is the first time I've worked with GTK, so please make sure I have not made any mistakes with the GTK related logic.

Kinnin Vo-Shay (vo-shay) wrote :

Could this be considered for the 5.2 release?

Also, would it help if I checked my changes in on a branch?

Maxime DOYEN (mdoyen) wrote :

I have already completely rewritten the import for multiple file, this is planned to 5.3 as other wish are more waited for.
So I add this to 5.3 as well.

Changed in homebank:
milestone: none → 5.3
assignee: nobody → Maxime Doyen (mdoyen)
Kinnin Vo-Shay (vo-shay) wrote :

Great!

Maxime DOYEN (mdoyen) on 2017-09-16
Changed in homebank:
milestone: 5.3 → 5.2
Maxime DOYEN (mdoyen) on 2017-10-06
Changed in homebank:
status: New → In Progress
Maxime DOYEN (mdoyen) on 2017-10-08
Changed in homebank:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers