|| input in split should not be possible

Bug #1502997 reported by slodki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HomeBank
Fix Released
Low
Maxime DOYEN

Bug Description

There is no warning when you enter || into split memo field. But such splits are lost during loading saved xhb file (see http://bazaar.launchpad.net/~mdoyen/homebank/main/view/head:/src/hb-transaction.c#L1166).

There should be some validation for memo fields in splits, then you should not allow enter ||, or escape them in some way when generating XML. User must be warned before data is lost (before saving non-parseable value).

Revision history for this message
slodki (slodki) wrote :

Maybe solution is to change xhb file format from flat to structured xml like below, not storing multiple values in one field? Using nested structure with defined optional elements and
It would be easily managed with xml schema validation, DOM, XPath etc.

wallet
  account list
    account
      transaction
      transaction
        split
        split
        split
      transaction
    account
      transaction
  internal transfer list
    transaction
    transaction
    transaction
    transaction
  category list
    category
    category
      subcategory
    category
      subcategory
      subcategory
    category
      subcategory
    category
  payee list
    payee
    payee
    payee
    payee
  assignment list
    rule
      payee
    rule
      category
      payee
    rule
      payee
    rule
      category
      payee

Revision history for this message
Maxime DOYEN (mdoyen) wrote :

the file structure change is something in my trunk backlog.
by waiting, yes I will disable || input

summary: - Splits with || in memo are lost when opening xhb file
+ || input in split should not be possible
Maxime DOYEN (mdoyen)
Changed in homebank:
assignee: nobody → Maxime Doyen (mdoyen)
importance: Undecided → Low
milestone: none → 5.0.6
status: New → Fix Committed
Maxime DOYEN (mdoyen)
Changed in homebank:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.