invalid reads from hipd reported by Valgrind

[David Martin]

Valgrind reports invalid reads when it is run on hipd. You can reproduce it with
sudo valgrind --undef-value-errors=no --log-file=my_logfile.log hipd/hipd -dk
and initiate a base exchange with another hipd, for example by ping6 HIT.

The reported errors look like this:

==1228== Invalid read of size 4
==1228== at 0x436A2C: hip_print_hit (debug.c:746)
==1228== by 0x40ECDB: hip_del_peer_info_entry (hadb.c:890)
==1228== by 0x40857D: hip_close_ack_handle_packet (close.c:482)
==1228== by 0x42119C: hip_run_handle_functions (pkt_handling.c:161)
==1228== by 0x418D69: hip_receive_control_packet (input.c:577)
==1228== by 0x419048: hip_receive_udp_control_packet (input.c:643)
==1228== by 0x411123: hip_run_socket_handles (hip_socket.c:307)
==1228== by 0x411EE8: main (hipd.c:403)
==1228== Address 0x5e2d1e0 is 16 bytes inside a block of size 80 free'd
==1228== at 0x4C27D71: free (vg_replace_malloc.c:366)
==1228== by 0x40ECB8: hip_del_peer_info_entry (hadb.c:889)
==1228== by 0x40857D: hip_close_ack_handle_packet (close.c:482)
==1228== by 0x42119C: hip_run_handle_functions (pkt_handling.c:161)
==1228== by 0x418D69: hip_receive_control_packet (input.c:577)
==1228== by 0x419048: hip_receive_udp_control_packet (input.c:643)
==1228== by 0x411123: hip_run_socket_handles (hip_socket.c:307)
==1228== by 0x411EE8: main (hipd.c:403)

Full log from hipd revision 5937 on trunk is attached.