Remove hip_in6_ntop and use inet_ntop instead

Bug #701873 reported by Samu Varjonen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HIPL
Confirmed
Low
Samu Varjonen

Bug Description

hip_in6_ntop produces non-RFC3849-compliant IPv6 addresses. Does not remove leading zeroes. The function seems to be a leftover from the kernel times anyway. I cannot see a reason why not to use inet_ntop instead.

Revision history for this message
Samu Varjonen (sklvarjo) wrote :

Or RFC 5952? Anyway the leading zeroes are useless and the point was that the hip_in6_ntop is useless.

Revision history for this message
René Hummen (rene-hummen) wrote :

I agree. Samu, please go ahead and fix the issue. Please make sure to remove all references (e.g., in the unit-tests) to hip_in6_ntop. Thanks.

Changed in hipl:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Samu Varjonen (sklvarjo)
Revision history for this message
Samu Varjonen (sklvarjo) wrote :

I will remove them as soon as possible. Is there any objections if I remove the hip_convert_string_to_address on the same go and replace it with inet_pton? Used only in three places in hipconf. This would remove the lib/core/straddr.c(h) files and the test/lib/core/straddr.c file as useless.

Revision history for this message
Miika Komu (miika-iki) wrote :

Go ahead. Some developers might prefer two different (atomic) commits for the separate macros.

Revision history for this message
Samu Varjonen (sklvarjo) wrote :

OK, removing hip_convert_string_to_address as a separate commit...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.