SPKI signature fails in encoding of B64

[Samu Varjonen]

debug(hipd/cert.c:108@hip_cert_spki_sign): Getting keys for HIT: 2001:001a:7139:10ad:bb56:f1d3:d3d1:83c4
error(hipd/cert.c:201@hip_cert_spki_sign): Failed to encode digest_b64
error(hipd/user.c:384@hip_handle_user_msg): Signing SPKI cert returned an error
debug(hipd/hip_socket.c:145@hip_handle_user_sock): Send response
debug(hipd/hip_socket.c:151@hip_handle_user_sock): Sending message (type=141) response to port 1001

[Samu Varjonen (sklvarjo)]

trunk 5458

[Diego Biurrun (diego-biurrun)]

What do you mean exactly by "trunk 5458"? Does the bug exist in that revision? Was it fixed in that revision?

[Samu Varjonen (sklvarjo)]

Tested with revision 5458.

[Christoph Viethen (cviethen)]

The bug turned up in revision 5091 (due to wrong processing of EVP_EncodeBlock() return code). Just changing that didn't help - some more breakage had to be removed. RSA version should be fully functional again since rev. 5662.

I'll leave this open for the moment since I suspect similar trouble (of the memory corruption kind) in the DSA portions of the code which still need to be addressed (no pun intended).

[Miika Komu (miika-iki)]

Are you using valgrind or some other tool to verify these?

[Christoph Viethen (cviethen)]

gdb was my weapon of choice this time around. Will take a look at valgrind & fixing the rest of this function as time permits (memory bugfixing not being my primary goal these days).

[Miika Komu (miika-iki)]

Have you checked out efence? Maybe it's better than gdb for the job.

[Miika Komu (miika-iki)]

apt-get install electric-fence